Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storage): skip error log if storage config is 0 #1300

Closed
wants to merge 1 commit into from

Conversation

njgheorghita
Copy link
Collaborator

@njgheorghita njgheorghita commented May 17, 2024

What was wrong?

If storage capacity is set to 0, you get a whole lot of these ERROR warnings, which also sets the data_radius to MAX incorrectly.

How was it fixed?

Skip pruning if storage config is set to 0

To-Do

@njgheorghita
Copy link
Collaborator Author

Actually, not sure yet if this is the best way to solve this...

@morph-dev
Copy link
Collaborator

Probably the correct way would be to set radius to zero during init. I can add that logic to my PR #1295 that is already refactoring pruning.

Btw, what is the error that you are seeing?
"Farthest not found!" or "Pruning requested but we are below target capacity" or both or something else?

@morph-dev
Copy link
Collaborator

Added logic to #1295. It will also make sure to empty the db (prune everything) at the startup.

@njgheorghita
Copy link
Collaborator Author

@morph-dev it's the Farthest not found! error, also if you check the scatter plot on glados, you can see that the bridge nodes are being incorrectly set to a radius of 100. But, imo it seems that probably the correct way would be to set radius to zero during init. is the way to go and should solve these issues. Closing this pr in favor of #1295

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants