Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(beacon-storage): store HistoricalSummariesWithProof content and add beacon storage tests #1299

Merged
merged 1 commit into from
May 25, 2024

Conversation

ogenev
Copy link
Member

@ogenev ogenev commented May 16, 2024

What was wrong?

We don't store HistoricalSummariesWithProof in db.

How was it fixed?

  • store the latest "HistoricalSummariesWithProof" version in the beacon cache storage
  • add tests for beacon storage

To-Do

@ogenev ogenev self-assigned this May 16, 2024
@ogenev ogenev changed the title feat(beacon-network): store HistoricalSummariesWithProof content and add beacon storage tests feat(beacon-storage): store HistoricalSummariesWithProof content and add beacon storage tests May 16, 2024
@ogenev ogenev added this to the Beacon Network milestone May 16, 2024
@ogenev ogenev force-pushed the historical-summaries-storage branch 3 times, most recently from cf82b3d to 27d7486 Compare May 24, 2024 16:31
@ogenev ogenev force-pushed the historical-summaries-storage branch from 27d7486 to 64c6907 Compare May 24, 2024 18:43
@ogenev ogenev marked this pull request as ready for review May 24, 2024 18:52
Copy link
Member

@KolbyML KolbyML left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@ogenev ogenev merged commit cafa8df into ethereum:master May 25, 2024
8 checks passed
@ogenev ogenev deleted the historical-summaries-storage branch May 25, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants