feat(portalnet): add rfn lookup to gossip #1267
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
njgheorghita
force-pushed
the
gossip-rfn
branch
from
f54b0f0
to
5ed9bf7
Compare
KolbyML
reviewed
Apr 24, 2024
Comment on lines
-63
to
-67
| if all_nodes.is_empty() { | ||
| // If there are no nodes whatsoever in the routing table the gossip cannot proceed. | ||
| warn!("No nodes in routing table, gossip cannot proceed."); | ||
| return 0; | ||
| } |
|
I think the same result would have happened if you ran master on your home node running latest. So I think both cases should have been tested as a control. Debugging and fixing why we are having provider issues is the highest issue then this. I do think this is a smarter way of gossipping. But I think "solving"
Without the logs or seeing if there was provider errors I don't think I can comment anything of value on the results you told me of the tested you reported to me earlier today |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
How was it fixed?
To-Do