Feat: --ephemeral should use a non-default port solution #1124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KaydenML
force-pushed
the
ephemeral-shou
branch
from
31f5ccf
to
d764cc0
Compare
KaydenML
changed the title
|
Do we want this or not? If not I am going to close this pr and the issue for it, I will give it a month or some amount of time which feels right. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Fixes: #919
If someone was using a default port and used --ephemeral twice in a row, or run ephemeral and then a non-ephemeral run. Because a bunch of former peers are contacting you on that port, expecting a different public key, your logs get flooded with warnings about incoming packets that can't be decoded
How was it fixed?
This code sets the discovery port. If in ephemeral mode with the default port, it generates a random port between 30000 and 60000 otherwise it uses the specified discovery port to avoid log flooding issues during consecutive ephemeral runs or mode switches.