Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--ephemeral should use a non-default port #919

Open
carver opened this issue Sep 15, 2023 · 2 comments · May be fixed by #1124
Open

--ephemeral should use a non-default port #919

carver opened this issue Sep 15, 2023 · 2 comments · May be fixed by #1124
Labels
good-first-issue Good for newcomers

Comments

@carver
Copy link
Collaborator

carver commented Sep 15, 2023

If a port isn't explicitly specified, and the --ephemeral flag is set, then we should set a different port.

The main annoyance of using the default port is if you use --ephemeral twice in a row, or run ephemeral and then a non-ephemeral run. Because a bunch of former peers are contacting you on that port, expecting a different public key, your logs get flooded with warnings about incoming packets that can't be decoded. (This happened on Joseph Cook's first contact with trin)

Maybe chose the port based on the generated node-id, to help spread it out across runs? Maybe randomize the port?

@carver carver added the good-first-issue Good for newcomers label Sep 15, 2023
@1010adigupta
Copy link

I can take up this, you can assign me

@KaydenML
Copy link
Contributor

Fixed this issue in this PR
#1124

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good-first-issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants