Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hometab updates #4774

Open
wants to merge 76 commits into
base: master
Choose a base branch
from
Open

Hometab updates #4774

wants to merge 76 commits into from

Conversation

joeizang
Copy link
Collaborator

Update the hometab of IDE based on designs on excalidraw from @LianaHus

@joeizang joeizang added the WIP label Apr 30, 2024
@joeizang joeizang self-assigned this Apr 30, 2024
Copy link

netlify bot commented Apr 30, 2024

Deploy Preview for remixproject ready!

Name Link
🔨 Latest commit 45fb472
🔍 Latest deploy log https://app.netlify.com/sites/remixproject/deploys/6666d02ba1e0c70008303bd7
😎 Deploy Preview https://deploy-preview-4774--remixproject.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@joeizang joeizang force-pushed the hometab-update-001 branch 3 times, most recently from bd1504c to 0450224 Compare May 9, 2024 10:43
@joeizang joeizang force-pushed the hometab-update-001 branch 2 times, most recently from 6699e85 to 518cd5d Compare May 17, 2024 08:05
@joeizang joeizang added this to In progress in v0.50.0 - Feature Freeze 03/06 via automation May 23, 2024
@joeizang joeizang added ready-to-review PR ready to review and removed WIP labels May 23, 2024
@joeizang joeizang marked this pull request as ready for review May 23, 2024 09:26
@LianaHus
Copy link
Collaborator

LianaHus commented May 29, 2024

  • New file should create a file in current workspace
  • some more spacing for title of File section (Exlpore...)
  • add space after recent section and remove from the top of it
  • slides should have more height
  • for the Connect to Local File system button
  • Alert alert-danger for alerts on the status bar and danger text color for icon and the text
  • Alert window height should be adjusted
  • align sections on status bar
  • increase a margin-bottom for toaster
  • If the workspace is not a github repo the text "not a git repo" can become a btn "init as git repo"
  • all status bar sections should have tooltips
  • for next iteration: Plugins from the selected list should be able to register a component/html el and a callback.

@joeizang joeizang force-pushed the hometab-update-001 branch 5 times, most recently from 02d654f to 2e04cbb Compare June 3, 2024 18:22
Copy link
Collaborator

@ryestew ryestew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exciting PR!!
I do have some comments:
the visited link in the red is a bit dark:
image

This is a minor issue - so it can be merged as is.

A more important point is that because LearnEth is gone, there should be links to it from one of the scrolling boxes. This request is outside of this PR.

@vermouth22
Copy link
Collaborator

vermouth22 commented Jun 4, 2024

Looks great! However one fundamental issue, take note the attached image is the res seen on a 13 inch Mac M1 laptop. This shows even less real estate than the existing IDE hometab.

  1. Something should be done on progressive resolution changes per machine. Or, a combination of moving things up. Like shortening the vertical dimension of the new "Featured" panel, etc. Also, where to click through to "LearnEth"?
  2. Tagline for Remix should say: "Learn. Explore. Create." because "Native IDE" we decided a while ago, has no meaning
  3. Links below tagline should be "Website Remix Desktop Documentation" ... In this iteration there are two links for Desktop
  4. Tagline below that (above Start Coding)... "Explore. Prototype. Create" should be removed
  5. "Recent workspaces", should be rendered in U/L so it should read "Recent Workspaces"
  6. "Connect to local filesystem" should also be U/L so it should read "Connect to Local Filesystem"
image

@vermouth22
Copy link
Collaborator

@joeizang Getting closer. FYI, there's still a bit of the feature panel cut off horizontally. And, now somehow need to lift up the Featured Plugins list...
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants