Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate solidity scan in udapp #4735

Merged
merged 23 commits into from
Jun 10, 2024
Merged

Integrate solidity scan in udapp #4735

merged 23 commits into from
Jun 10, 2024

Conversation

Aniket-Engg
Copy link
Collaborator

@Aniket-Engg Aniket-Engg commented Apr 17, 2024

  1. Expand Udapp instance
  2. See QR scan within the instance on right side
  3. Click on it and go with the instructions

Copy link

netlify bot commented Apr 17, 2024

Deploy Preview for remixproject ready!

Name Link
🔨 Latest commit 0bf6ee7
🔍 Latest deploy log https://app.netlify.com/sites/remixproject/deploys/6666e7f158325300095c9785
😎 Deploy Preview https://deploy-preview-4735--remixproject.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@yann300
Copy link
Contributor

yann300 commented Jun 3, 2024

Modal UX isn't really working ok, I don't want to interfer with any UX decision, but it seems to me that logging the result to the terminal is just fine.
Also you won't have the issue of having to design a modal..

@Aniket-Engg
Copy link
Collaborator Author

Modal UX isn't really working ok, I don't want to interfer with any UX decision, but it seems to me that logging the result to the terminal is just fine. Also you won't have the issue of having to design a modal..

Terminal will also not be better to show this data IMO. May be we can adjust the modal size.

@LianaHus
Copy link
Collaborator

LianaHus commented Jun 4, 2024

  • For the user who doesn't know what solidity scan is, the tooltip says nothing. Can you expand there?
  • The modal for permission makes me anxious because I still don't know what solidity scan is, and I should share my code now. I would 99% not do it with this data. To improve this we can add more info in the modal and include the link to the project.
  • columns are too narrow. I assume this is because you are using our default modal and it has some restrictions. you can either create a custom one or alter the existing one to have 2-3 more views
  • there are some

    tags in your rightmost column

  • close is not closing the modal for me

Screenshot from 2024-06-04 08-24-41

@Aniket-Engg
Copy link
Collaborator Author

Aniket-Engg commented Jun 4, 2024

  • For the user who doesn't know what solidity scan is, the tooltip says nothing. Can you expand there?

Updated! Please check

  • The modal for permission makes me anxious because I still don't know what solidity scan is, and I should share my code now. I would 99% not do it with this data. To improve this we can add more info in the modal and include the link to the project.

Updated! Please check

  • there are some tags in your rightmost column

This has been handled. Tags should not be there

  • close is not closing the modal for me

It is working fine for me

@Aniket-Engg Aniket-Engg removed this from In progress in v0.50.0 - Feature Freeze 03/06 Jun 4, 2024
@Aniket-Engg Aniket-Engg force-pushed the solscan branch 2 times, most recently from 0c1b0f2 to 9f9ca07 Compare June 5, 2024 14:55
@Aniket-Engg
Copy link
Collaborator Author

@yann300 @LianaHus I have increased modal size and handled your comment.

@Aniket-Engg Aniket-Engg merged commit 14337c1 into master Jun 10, 2024
32 checks passed
@Aniket-Engg Aniket-Engg deleted the solscan branch June 10, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants