This repository has been archived by the owner on May 23, 2023. It is now read-only.
solidity_names() recognizes interface #737
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LefterisJP
added a commit
to LefterisJP/raiden
that referenced
this pull request
Jun 1, 2017
LefterisJP
added a commit
to LefterisJP/raiden
that referenced
this pull request
Jun 1, 2017
Based directly on top of pyethereum v1.6.1 This is a hack. Solidity 0.4.11 introduces the interface keyword and breaks the solidity_names() function. This simply tweaks the function so that it also treats interfaces like contracts and does not break. I don't believe pyethereum should attempt to parse solidity files on its own as compatibility issues like this are almost certain to arise also in the future. For more long-term a different solution should be found where pyethereum queries solidity itself and does not parse anything on its own.
LefterisJP
force-pushed
the
take_solidity_interface_into_account
branch
from
82e7896
to
246bc3d
Compare
LefterisJP
added a commit
to LefterisJP/raiden
that referenced
this pull request
Jun 1, 2017
LefterisJP
added a commit
to LefterisJP/raiden
that referenced
this pull request
Jun 2, 2017
LefterisJP
added a commit
to LefterisJP/raiden
that referenced
this pull request
Jun 2, 2017
LefterisJP
added a commit
to raiden-network/raiden
that referenced
this pull request
Jun 2, 2017
|
Resolve conflicts then will merge |
|
@joeykrug I will do that, but since we have this branch pinned in raiden and I don't want to introduce extra problems with our code by using a newer pyethereum version I will probably do it in a new PR. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a hack. Solidity 0.4.11 introduces the
interfacekeyword andbreaks the
solidity_names()function. This simply tweaks the functionso that it also treats interfaces like contracts and does not break.
I don't believe pyethereum should attempt to parse solidity files on its
own as compatibility issues like this are almost certain to arise also in the
future. For more long-term a different solution should be found where
pyethereum queries solidity itself and does not parse anything on its own.