This repository has been archived by the owner on May 23, 2023. It is now read-only.
ported most of the serpent contracts from test_contracts.py to solidity
#362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| SOLIDITY_AVAILABLE = get_solidity() is not None | ||
|
|
||
|
|
||
| @pytest.mark.skipif(not SOLIDITY_AVAILABLE, reason='solc compiler not available') |
There was a problem hiding this comment.
It might be nice to roll this up into something reusable so that it isn't repeated for every test in the file.
skip_if_no_solidity_compiler = pytest.mark.skipif(not SOLIDITY_AVAILABLE, reason='solc compiler not available')
@skip_if_no_solidity_compiler
def test_things():
...There was a problem hiding this comment.
sure, though imo it shouldn't have that check considering solidity > serpent
but I guess the setup.py should install solc in that case ...
rubensayshi
force-pushed
the
solidity-tests
branch
2 times, most recently
from
6088bbd
to
316b9b0
Compare
…dity and added a few extra.
rubensayshi
force-pushed
the
solidity-tests
branch
from
316b9b0
to
9392986
Compare
|
added a bunch more;
|
|
Oh would love to merge once conflict fixed :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
figured since serpent is kinda being deprecated it would be nice to have all the tests in solidity (as well).
also added a few new ones for things that weren't covered yet.
test_subcall_suiciderfails because #360