Skip to content
This repository has been archived by the owner on May 23, 2023. It is now read-only.

Python3 support progress #238

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

ouziel-slama
Copy link
Contributor

No description provided.

@ouziel-slama
Copy link
Contributor Author

@vbuterin, with this PR all tests that pass with Python 2 also pass with Python 3. Here a document with the state off all tests: https://docs.google.com/spreadsheets/d/1jaw7Gb6W_dCtvs2ujE58bmKNg_Ld16VxvXId29vAP2U

@adamkrellenstein
Copy link

@heikoheiko, @vbuterin, will you be okay with this PR when it's been rebased?

@heikoheiko
Copy link
Member

Hi Adam,
thanks for the work. But we experienced some performance penalties (in the vm) introduced due the compatibility.

Can you make sure, that heavily looped code (like in the vm) does never call any py2/3 compatibility related isinstance.

Also note, that we probably nowhere use unicode in ethereum. It can safely be assumed, that it's either bytes or long. Except for input from json, which should be converted as soon it was deserialized.

see profile_vm.py in the pypy branch for an easy option to profile the code.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants