Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core/state: remove useless operation #29769

Merged
merged 1 commit into from
May 14, 2024

Conversation

rjl493456442
Copy link
Member

Originally updateTrie will try to finalize the dirty storages first before trie committing. This operation is removed in this pull request, reasons as below:

  • Before the updateTrie, all the finalization has already been done in IntermediateRoot, the operation here is duplicated
  • The prefetcher has been terminated at that time and if there are some leftover slots, they will be failed for prefetching

Copy link
Contributor

@holiman holiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@holiman holiman added this to the 1.14.4 milestone May 14, 2024
@holiman holiman merged commit be32843 into ethereum:master May 14, 2024
3 checks passed
fjl pushed a commit to fjl/go-ethereum that referenced this pull request May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants