eth/gasestimator: include blobs in virtual balance computation #29703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fjl
changed the title
fjl
reviewed
May 6, 2024
| if opts.Config.IsCancun(opts.Header.Number, opts.Header.Time) && len(call.BlobHashes) > 0 { | ||
| blobBalanceUsage := new(big.Int).SetInt64(int64(len(call.BlobHashes) * params.BlobTxBlobGasPerBlob)) | ||
| blobBalanceUsage.Mul(blobBalanceUsage, call.BlobGasFeeCap) | ||
| available.Sub(available, blobBalanceUsage) |
There was a problem hiding this comment.
I think we need another check for balance > blobBalanceUsage here, otherwise it could go negative.
There was a problem hiding this comment.
You're right! Which one of the following options would you use for the error?
- Using
core.ErrInsufficientFundsas error, keepinginsufficient funds for gas * price + valueas description, - Using
core.ErrInsufficientFundsas error, changing description toinsufficient funds for gas * price + blobGas * blobGasPrice + valueas description, - creating and using a new error,
ErrEip4844InsufficientFundswithinsufficient funds for gas * price + blobGas * blobGasPrice + valueas description ?
I guess option 3?
There was a problem hiding this comment.
Added option 1/ for now, let me know.
fjl
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for the bug descripted on #29702 -- I no longer see the bug.
I am new to go-ethereum codebase, so I may have missed things, please tell me :-)
Also, would you like some test with it?