Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core, core/state: move TriesInMemory to state package #29701

Merged
merged 1 commit into from May 6, 2024

Conversation

gballet
Copy link
Member

@gballet gballet commented May 3, 2024

The 128 layers is currently hardcoded in state, whereas that depth is left as a constant in core.

Move this constant so that the verkle code that consumes it, and needs a deeper tree, has to only modify a single location.

Copy link
Member

@rjl493456442 rjl493456442 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i am fine with it.

In long term, the whole complexity should be managed by a state database implicitly. But yeah, good for now.

@gballet gballet requested a review from rjl493456442 May 6, 2024 07:39
@fjl fjl merged commit 43cbcd7 into ethereum:master May 6, 2024
3 checks passed
@fjl fjl added this to the 1.14.1 milestone May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants