core/state: introduce stateupdate structure #29530
Open
+442
−342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjl493456442
force-pushed
the
state-update
branch
3 times, most recently
from
8e190d8
to
ea9d92e
Compare
rjl493456442
force-pushed
the
state-update
branch
4 times, most recently
from
005bb86
to
60746bb
Compare
rjl493456442
force-pushed
the
state-update
branch
6 times, most recently
from
354717c
to
bd6b20a
Compare
rjl493456442
force-pushed
the
state-update
branch
2 times, most recently
from
2fe48c1
to
2089fdb
Compare
holiman
reviewed
May 14, 2024
core/state/state_object.go
Outdated
Comment on lines
65
to
71
| // Note, this map will be reset for each transaction before byzantium fork. | ||
| needCommit Storage |
There was a problem hiding this comment.
Modified but not yet committed, this sounds a lot like dirtyStorage. Please add some clarification so a reader understands what's different between those two things
rjl493456442
force-pushed
the
state-update
branch
from
2089fdb
to
3d70c5b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request rewrites the statedb by introducing a state update struct.
A state update struct will be constructed once the
statedb.Commitis invoked. It contains all the statechanges caused by previous state transition, e.g.
Instead of committing the state change into state snapshot and trie database blindly, the state update
will be returned and then can be consumed by different state database implementation in different
ways. It gives more flexibilities to design database abstraction for different purposes.
What's more, the statedb has been simplified significantly, especially in state change construction.