trie, eth/protocols/snap: sanitize the committed node data #29485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
holiman
reviewed
Apr 8, 2024
| if !op.valid() { | ||
| return fmt.Errorf("invalid op, %s", op.string()) | ||
| } | ||
| if op.del { |
There was a problem hiding this comment.
Shouldn't you rewrite isDelete into:
func (op *nodeOp) isDelete() bool {
return op.del
}Alternatively: delete the method
There was a problem hiding this comment.
Yep, the method should be deleted
|
This PR seems simple and good, just maybe not needed (making the surrounding code harder to understand). My 2c, lets leave it open until the root cause for the sync issue is discovered and if it's related to this, we should merge. If it's unrelated, it might be better to close. |
rjl493456442
force-pushed
the
enhance-state-heal
branch
from
5dd69d6
to
5292ddb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds one more check before committing the trie nodes from the
trie.Syncer:The check is cheap enough and shouldn't have any performance impact.
The node blob cached in the
trie.Synceris not deep-copied, rather than a reference of the network packet.Theoretically it should be safe the hold the network packet reference being originated from here, although i am not 100% confident about it.
If it's possible to empties the referenced blob somehow, than it could be the root cause of #29436