core: implement EIP-2935 #29465
core: implement EIP-2935 #29465
Conversation
core/vm/eips.go
Outdated
|
|
||
| func getBlockHashFromContract(number uint64, statedb StateDB) common.Hash { | ||
| ringIndex := number % 256 | ||
| var pnum common.Hash |
There was a problem hiding this comment.
pnum isn't very helpful. pNum? but what is p?
There was a problem hiding this comment.
Renamed to slot as it is the encoded storage key for a given ancestor.
core/vm/eips.go
Outdated
| func enable2935(jt *JumpTable) { | ||
| jt[BLOCKHASH] = &operation{ | ||
| execute: opBlockhash2935, | ||
| // TODO: gas params |
There was a problem hiding this comment.
I ended up deleting the new BLOCKHASH implementation. We can just continue how we did it before. Specially since the spec doesn't update the gas price of the opcode.
|
@s1na, pinging you to be aware of some extra changes that happened on Kaustinen after you pulled the work from the other branch, see: gballet#411, which some days after where also updated in the EIP ethereum/EIPs@2b73ecb |
| if p.config.IsPrague(block.Number(), block.Time()) { | ||
| ProcessBlockHashHistory(statedb, block.Header(), p.config, p.bc) | ||
| } |
There was a problem hiding this comment.
This logic is a bit convoluted. There are basically two paths:
- On the exact fork-block: we need to iterate and add 256 hashes
- On every block after the fork: we need to add the parent hash.
The code, as written, makes path 1 the 'default-path'. We always enter the ProcessBlockHashHistory, which invokes ProcessParentBlockHash and just exits before iterating. IMO it would be more intuitive to default to path 2, invoke ProcessParentBlockHash by default, and only ever once invoke ProcessBlockHashHistory.
There was a problem hiding this comment.
Think of it this way: the parent's block hash is always inserted. The other 8191 block hashes are only inserted in a certain condition after the parent one. Also having one wrapping method makes the footprint inside state_processor, miner etc. smaller.
lightclient
force-pushed
the
eip-2935
branch
2 times, most recently
from
64e49c2
to
62cf853
Compare
Co-authored-by: Guillaume Ballet <gballet@gmail.com> Co-authored-by: Ignacio Hagopian <jsign.uy@gmail.com>
Copied over and adapted from https://github.com/gballet/go-ethereum/tree/kaustinen-with-shapella, following the latest changes to the spec: ethereum/EIPs#8166