eth/tracers: some simple adjustment for the testcase #29450
+38
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jsvisa <delweng@gmail.com>
Signed-off-by: jsvisa <delweng@gmail.com>
Signed-off-by: jsvisa <delweng@gmail.com>
Signed-off-by: jsvisa <delweng@gmail.com>
Signed-off-by: jsvisa <delweng@gmail.com>
s1na
reviewed
Apr 5, 2024
| result: result, | ||
| }; | ||
| if (traceConfig) { | ||
| data.tracerConfig = traceConfig; |
There was a problem hiding this comment.
Hm I think this is wrong. traceConfig is here something like { tracer: 'callTracer', traceConfig: {...}}. We should get the nested traceConfig.
There was a problem hiding this comment.
Oh yeah, you're right, I forgot this one.
s1na
reviewed
Apr 5, 2024
| @@ -15,6 +15,9 @@ var makeTest = function(tx, traceConfig) { | |||
| delete genesis.transactions; | |||
| delete genesis.transactionsRoot; | |||
| delete genesis.uncles; | |||
| delete genesis.withdrawals; | |||
| delete genesis.withdrawalsRoot; | |||
There was a problem hiding this comment.
This feels like a change for the sake of change :)
There was a problem hiding this comment.
Haha, I'm tracing another transaction, and the genesis includes lots of withdrawals logs, seems a little redundant
Signed-off-by: jsvisa <delweng@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made some simple adjustment for the trace testcase:
withdrawals{Root},genesis.baseFeePerGasinmakeTest.js;tracerConfiginmaketest.jsis not null;tracerTestEnvstruct;