Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core/state: logic equivalence for GetCodeHash #28733

Merged
merged 1 commit into from
Dec 26, 2023

Conversation

cygaar
Copy link
Contributor

@cygaar cygaar commented Dec 22, 2023

Every other getter in statedb follows the pattern of:

if stateObject != nil {
    return value
}
return defaultValue

I changed GetCodeHash to match this pattern

@rjl493456442 rjl493456442 added this to the 1.13.8 milestone Dec 26, 2023
@rjl493456442 rjl493456442 merged commit d2e3cb8 into ethereum:master Dec 26, 2023
2 of 3 checks passed
@MariusVanDerWijden MariusVanDerWijden modified the milestones: 1.13.8, 1.13.9 Jan 10, 2024
Dergarcon pushed a commit to specialmechanisms/mev-geth-0x2mev that referenced this pull request Jan 31, 2024
maoueh pushed a commit to streamingfast/go-ethereum that referenced this pull request Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants