Make daemon timeout configurable #953
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SamWilsn
reviewed
May 16, 2024
Comment on lines
88
to
97
| if self.shutdown_timeout != 0: | ||
| while True: | ||
| time.sleep(11.0) | ||
| now = time.monotonic() | ||
| last_response = self.last_response | ||
| if last_response is None: | ||
| self.last_response = now | ||
| elif now - last_response > float(self.shutdown_timeout): | ||
| self.shutdown() | ||
| break |
There was a problem hiding this comment.
Suggested change
| if self.shutdown_timeout != 0: | |
| while True: | |
| time.sleep(11.0) | |
| now = time.monotonic() | |
| last_response = self.last_response | |
| if last_response is None: | |
| self.last_response = now | |
| elif now - last_response > float(self.shutdown_timeout): | |
| self.shutdown() | |
| break | |
| while self.shutdown_timeout != 0: | |
| time.sleep(11.0) | |
| now = time.monotonic() | |
| last_response = self.last_response | |
| if last_response is None: | |
| self.last_response = now | |
| elif now - last_response > float(self.shutdown_timeout): | |
| self.shutdown() | |
| break |
|
|
||
| def __init__(self, *args: Any, shutdown_timeout: int, **kwargs: Any) -> None: | ||
| self.shutdown_timeout = shutdown_timeout | ||
| self.last_response = time.monotonic() |
There was a problem hiding this comment.
Won't this make the first check timeout if there is too much of a delay between creating the instance and starting the thread?
SamWilsn
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
The t8n daemon timeout can't be disabled.
How was it fixed?
Add a
--timeoutoption to the daemon.Cute Animal Picture