Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: EOF: Update test tracker #559

Merged
merged 2 commits into from
May 22, 2024
Merged

docs: EOF: Update test tracker #559

merged 2 commits into from
May 22, 2024

Conversation

gumb0
Copy link
Member

@gumb0 gumb0 commented May 15, 2024

🗒️ Description

Filling EOF test tracker.

🔗 Related Issues

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

@gumb0 gumb0 marked this pull request as draft May 15, 2024 14:18
marioevz
marioevz approved these changes May 15, 2024
View reviewed changes
Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@marioevz
Copy link
Member

@gumb0 I haven't merged this because it's not marked as ready for review, if it is ready just let me know and I can merge right away.

@gumb0 gumb0 force-pushed the fill-eof-tracker branch 3 times, most recently from 8a8b039 to 6d602d2 Compare May 22, 2024 10:42
@gumb0 gumb0 marked this pull request as ready for review May 22, 2024 11:15
@gumb0
Copy link
Member Author

gumb0 commented May 22, 2024

@marioevz Let's merge this, as the first version of container validation cases.

@poojaranjan poojaranjan mentioned this pull request May 22, 2024
Closed
@marioevz marioevz changed the title Update EOF test tracker docs: EOF: Update test tracker May 22, 2024
@marioevz marioevz merged commit 56a8249 into ethereum:main May 22, 2024
5 checks passed
@gumb0 gumb0 deleted the fill-eof-tracker branch May 22, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marioevz marioevz marioevz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gumb0 @marioevz