Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new(tests): EOF - EIP-663: EXCHANGE opcode #544

Merged
merged 15 commits into from
May 28, 2024
Merged

new(tests): EOF - EIP-663: EXCHANGE opcode #544

merged 15 commits into from
May 28, 2024

Conversation

shemnon
Copy link
Contributor

@shemnon shemnon commented May 3, 2024

🗒️ Description

Exercise the EXCHANGE operation. Builds off of #502

🔗 Related Issues

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

chfast and others added 9 commits April 26, 2024 17:33
@chfast
new(test): add tests for EOF/EIP-663 DUPN SWAPN
6da43f8
@chfast
improve code generation
b924e3d
@spencer-tb @shemnon
chore(ci): Update workflow actions to use Node.js 20 versions (ethere…
577a56f 
…um#527)

* chore(ci): Update workflow actions to use Node.js 20 versions.

* chore: Add changelog.
@shemnon
Add --traces support to besu (ethereum#511)
a67aa8f 
Add support for adding traces to output when using Besu.

Signed-off-by: Danno Ferrin <danno@numisight.com>
@marioevz @winsvega
@danceratopz @shemnon
feat(fw): call evmone-eofparse on generated EOF fixtures in fill (e…
b8ec060 
…thereum#519)

Co-authored-by: Dimitry Kh <dimitry@ethereum.org>
Co-authored-by: danceratopz <danceratopz@gmail.com>
@danceratopz @shemnon
docs(fix): small fix to tracing report in readme cf ethereum#511 (eth…
89bf1d9 
…ereum#539)
@shemnon
fix EOF return stack tests
b1c9384 
The tests were previously corrected against a bug in Besu,

Signed-off-by: Danno Ferrin <danno@numisight.com>
@shemnon
EXCHANGE
1d06f9e 
Exercise exchange operation

Signed-off-by: Danno Ferrin <danno@numisight.com>
@shemnon
speling
07cb277 
Signed-off-by: Danno Ferrin <danno@numisight.com>
@chfast
Copy link
Contributor

chfast commented May 14, 2024

All tests pass when execution with fill+evmone.

@shemnon shemnon changed the title EOF teste EXCHANGE EOF tests EXCHANGE May 20, 2024
shemnon and others added 6 commits May 22, 2024 16:27
@shemnon
merge main
c88060a 
Signed-off-by: Danno Ferrin <danno@numisight.com>
@shemnon
move
9d979c9 
Signed-off-by: Danno Ferrin <danno@numisight.com>
@shemnon
move to symbolic storage names
dab8126 
Signed-off-by: Danno Ferrin <danno@numisight.com>
@marioevz
feat(fw): Add EXCHANGE encoder
368e86c
@marioevz
new(tests): EOF - EIP-663: Invalid container due to invalid exchange
44e88dc
@shemnon
Merge pull request #2 from marioevz/eof/exchange
c58c3ff 
Eof/exchange
@marioevz marioevz changed the title EOF tests EXCHANGE new(tests): EOF - EIP-663: EXCHANGE opcode May 28, 2024
@marioevz marioevz merged commit ddae720 into ethereum:main May 28, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marioevz marioevz marioevz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@shemnon @chfast @marioevz @spencer-tb @danceratopz