Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EIP-3074: AUTH and AUTHCALL tests #543

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Conversation

SamWilsn
Copy link
Contributor

@SamWilsn SamWilsn commented May 3, 2024

πŸ—’οΈ Description

Initial tests for EELS implementation of EIP-3074.

πŸ”— Related Issues

ethereum/execution-specs#945

βœ… Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

@SamWilsn SamWilsn changed the title Eip 3074 EIP-3074: AUTH and AUTHCALL tests May 3, 2024
Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of comments.

tests/prague/eip3074_auth_authcall/test_auth.py Outdated Show resolved Hide resolved
tests/prague/eip3074_auth_authcall/test_auth.py Outdated Show resolved Hide resolved
tests/prague/eip3074_auth_authcall/test_auth.py Outdated Show resolved Hide resolved
@SamWilsn SamWilsn force-pushed the eip-3074 branch 3 times, most recently from c07cd57 to e4e42a2 Compare May 5, 2024 02:22


@pytest.mark.valid_from("Prague")
def test_stack_underflow(state_test: StateTestFiller) -> None:
Copy link
Collaborator

@winsvega winsvega May 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I remember here Ori asked if it is possible to get vmtrace, because it contains an error code that we want to check here. such as stack underflow. because otherwise the test could potentially fail with OOG and we didn't check the exception

@marioevz

or, perhaps there is a way to yell this excpetion in t8n output files as a special field.
because tx didn't fail, but the vm exception occured

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants