new(tests): EOF - EIP-6206: JUMPF Tests #540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests the assertsions in EIP-6206. Both container validation and runtime execution are validated. Signed-off-by: Danno Ferrin <danno@numisight.com>
winsvega
reviewed
May 3, 2024
winsvega
reviewed
May 3, 2024
winsvega
reviewed
May 3, 2024
winsvega
reviewed
May 3, 2024
winsvega
reviewed
May 3, 2024
winsvega
reviewed
May 3, 2024
- move to parameterized calls - combine eof and state tests in one go - change file groupings Signed-off-by: Danno Ferrin <danno@numisight.com>
winsvega
reviewed
May 6, 2024
winsvega
reviewed
May 6, 2024
winsvega
reviewed
May 6, 2024
winsvega
reviewed
May 6, 2024
winsvega
reviewed
May 6, 2024
Add comments to stack calculation variables. Signed-off-by: Danno Ferrin <danno@numisight.com>
marioevz
reviewed
May 8, 2024
There was a problem hiding this comment.
Looks good, one open question is whether we want the kind of logic from execute_tests to be embedded directly into the eof_test logic. This would enable generating state or blockchain tests for all EOF tests automatically, but my main concern is that it would be a lot of them.
marioevz
reviewed
May 23, 2024
| ids=lambda x: "to-%s" % ("N" if x == NON_RETURNING_SECTION else x), | ||
| ) | ||
| @pytest.mark.parametrize( | ||
| "current_outputs", |
There was a problem hiding this comment.
Thinking that changing the word "current" to "source" (so we would have source section and target section) might make it easier to understand. Wdyt @shemnon ?
There was a problem hiding this comment.
sounds good. It also matches the EIP better.
Signed-off-by: Danno Ferrin <danno@numisight.com>
Signed-off-by: Danno Ferrin <danno@numisight.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Description
Tests the assertsions in EIP-6206. Both container validation and
runtime execution are validated.
🔗 Related Issues
✅ Checklist
mkdocs servelocally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.