Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new(test): self-destruct test for nonce > 1 self-destructing contracts #478

Merged
merged 4 commits into from
May 24, 2024

Conversation

marioevz
Copy link
Member

@marioevz marioevz commented Mar 15, 2024

🗒️ Description

  • Adds a new test where the self-destructing contract also creates a new contract at some point in order to increase its nonce before successfully self-destructing, all in the same transaction.
  • Removes Yul requirement from the tests/cancun/eip6780_selfdestruct/test_selfdestruct.py file.

Note: Function test_create_selfdestruct_same_tx_increased_nonce is mostly a copy-paste of function test_create_selfdestruct_same_tx, with only lines 1484-1490 representing the new check for the created contracts.

🔗 Related Issues

None

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

@marioevz marioevz added scope:tests Scope: Test cases type:test Type: Test labels Mar 15, 2024
Copy link
Collaborator

@spencer-tb spencer-tb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

docs/CHANGELOG.md Outdated Show resolved Hide resolved
marioevz and others added 2 commits May 24, 2024 08:57
Co-authored-by: spencer <spencer.taylor-brown@ethereum.org>
@marioevz marioevz merged commit 667a068 into ethereum:main May 24, 2024
1 of 5 checks passed
@marioevz marioevz deleted the selfdestruct-increased-nonce-test branch May 24, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope:tests Scope: Test cases type:test Type: Test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants