Port casper_tester from tester to tester2 #11
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add mine_and_init_epoch() * Add epoch_blockhash() for getting the blockhash at a specific epoch * Change t.k0 to just k0 * Change a few tests to pass
*Turn the Casper chain setup into a method to allow it to be reused when initializing the chain during test 2
*Port second round of tests *Change tester2 to raise TransactionFailed() if a tx doesn't go through. This allows us to distinguish between a contract returning False and a tx exception *Remove a few unneeded t.mine() statements
|
@karlfloersch Looks like this PR should probably be closed |
|
This PR still references compare/commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ports
simple_casper_testerto usetester2from Pyethereum state_revamp.This PR requires the changes to
tester2proposed in ethereum/pyethereum#717Changes
simple_casper.v.pynow checks for blockhashes before awarding rewards.epoch_blockhash()andmine_and_init_epochs()casper_utils.pyinpyethereum. However, there were some organizational issues I faced when trying to include it there, and so I'm holding off for now. This is a pretty simple change which shouldn't add too much to the code complexity.