This repository has been archived by the owner on Oct 28, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Retesteth support #5909
Open
winsvega
wants to merge
7
commits into
master
Choose a base branch
from
updatetests2
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Retesteth support #5909
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
635aacc
fix rlpStream construction issue in blockchain tests
winsvega 000791f
update tests
winsvega d51b934
remove empty stEwasmTests
winsvega 64262c7
no leading zeros in tx r,s json output
winsvega 8fadd48
eth_getBlockBy* empty extraData is exported as "0x"
winsvega e9e0730
CALLBlake2f_MaxRounds take too much time
winsvega 9078d51
do not fail on unsupported test network.
winsvega File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Submodule jsontests
updated
19329 files
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it supposed to fix the case when block number doesn't in 64 bit?
But it doesn't fix it, because
m_number
is stilluint64_t
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also there are some proposals to require the limit for block nuumber and timestamp, so I'm not sure it makes sense to change it now.
https://eips.ethereum.org/EIPS/eip-1985
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It fixes the test. Because RLPStream << was working incorrectly with u64int_t
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you mean exactly? Maybe we should fix
operator<<
foruint64_t
or something(Some tests currently fail anyway)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. I had blockchain/invalidblocks/bcInvalidHeader/timestamp4 test failing without this change. I assume the issue is in << operation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't find this test, what are header values there?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry I was out of laptop.
it is this test:
BlockchainTests/InvalidBlocks/bcUncleHeaderValidity/incorrectUncleTimestamp4
I set timestamp of the uncleheader to 500000000000 + previous block (~1000)
and the value I get
rlp::85746a528800
. but testeth gives me RLP encode of this argumentrlp::846a528800
unless I explicitly say that it is a bigint in that function. the fix is dirty because I just try to make the tests pass