This repository has been archived by the owner on Oct 28, 2021. It is now read-only.
aleth-precompiles library #5855
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5855 +/- ##
==========================================
+ Coverage 63.94% 63.96% +0.02%
==========================================
Files 365 364 -1
Lines 31098 31103 +5
Branches 3441 3441
==========================================
+ Hits 19885 19895 +10
+ Misses 9980 9974 -6
- Partials 1233 1234 +1 |
gumb0
force-pushed
the
libaleth-precompiles
branch
from
e325253
to
8da9bc0
Compare
Use it in Executive to execute precompiles.
gumb0
force-pushed
the
libaleth-precompiles
branch
from
39a5403
to
c570e3b
Compare
chfast
reviewed
Jan 3, 2020
| extern "C" { | ||
| #endif | ||
|
|
||
| EVMC_EXPORT struct evmc_vm* evmc_create_aleth_precompiles_vm() EVMC_NOEXCEPT; |
There was a problem hiding this comment.
If the library name is aleth-precompiles this should be named evmc_create_aleth_precompiles for EVMC loader to work.
|
What was the blocker on this? Lack of time / lack of usefulness? |
Rather lack of usefulness. But this PR is ready from my side except |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5788
This replaces the precompiles infrastructure with the new EVMC module library.
Information about which revision activates each precompile for now is still in
ChainParamsclass.Option to build as a shared library is not added yet.