This repository has been archived by the owner on Oct 28, 2021. It is now read-only.
CMake: Use basic compiler settings from Cable #5407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gumb0
approved these changes
Dec 20, 2018
gumb0
suggested changes
Dec 20, 2018
Codecov Report
@@ Coverage Diff @@
## master #5407 +/- ##
==========================================
+ Coverage 61.15% 61.16% +<.01%
==========================================
Files 344 344
Lines 28321 28321
Branches 3238 3238
==========================================
+ Hits 17321 17322 +1
Misses 9866 9866
+ Partials 1134 1133 -1 |
|
Windows build still fails |
|
Yes I know. Looks like I have to spin off Windows machine to solve this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.