Skip to content
This repository has been archived by the owner on Oct 28, 2021. It is now read-only.

Refactor libp2p::Peer #5265

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Refactor libp2p::Peer #5265

wants to merge 4 commits into from

Conversation

gumb0
Copy link
Member

@gumb0 gumb0 commented Sep 12, 2018

I don't remember exactly where I went with this, but my best guess is that I wanted to achieve the following:

  • Remove the ability to change Peer's endpoint. When endpoint changes, new Peer instance should be created.
  • Get rid of inheritance Peer->Node, make Node a member of Peer instead.
  • Get rid of friends of Peer (RLPXHandshake looks already not required to be a friend)

@codecov-io
Copy link

codecov-io commented Sep 12, 2018

Codecov Report

Merging #5265 into master will increase coverage by 0.03%.
The diff coverage is 72.5%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5265      +/-   ##
==========================================
+ Coverage   62.33%   62.37%   +0.03%     
==========================================
  Files         350      350              
  Lines       29428    29427       -1     
  Branches     3322     3321       -1     
==========================================
+ Hits        18344    18354      +10     
+ Misses       9886     9878       -8     
+ Partials     1198     1195       -3

@gumb0
Copy link
Member Author

gumb0 commented May 29, 2019

Rebased.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants