-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ERC: Tokenized Vaults with Lock-in Period #406
Open
Ankarrr
wants to merge
10
commits into
ethereum:master
Choose a base branch
from
Ankarrr:erc-draft-tokenized-vault-with-lock-in-period
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add ERC: Tokenized Vaults with Lock-in Period #406
Ankarrr
wants to merge
10
commits into
ethereum:master
from
Ankarrr:erc-draft-tokenized-vault-with-lock-in-period
+321
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ankarrr
force-pushed
the
erc-draft-tokenized-vault-with-lock-in-period
branch
from
May 9, 2024 14:05
a123082
to
0715347
Compare
Hey @axic, @g11tech, @SamWilsn, @xinbenlv, This EIP extends the ERC-4626 Tokenized Vaults with the lock-in period. It has been reviewed at ethereum/EIPs#6229, and all issues have been resolved. I believe this PR can be easily reviewed. I would appreciate it if you could help me review this. Please let me know if you have any questions. Thank you! Sincerely, |
Ankarrr
force-pushed
the
erc-draft-tokenized-vault-with-lock-in-period
branch
from
May 17, 2024 03:41
0715347
to
897770d
Compare
Ankarrr
force-pushed
the
erc-draft-tokenized-vault-with-lock-in-period
branch
from
May 30, 2024 07:48
897770d
to
175dddc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is migrated from ethereum/EIPs#6229.
This draft ERC is an extension of the ERC-4626 Tokenized Vaults designed to support the lock-in period.
I used the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md