-
Notifications
You must be signed in to change notification settings - Fork 341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ERC-1363: Update text to modern recommendations #403
Open
vittominacori
wants to merge
8
commits into
ethereum:master
Choose a base branch
from
vittominacori:feat/update-texts-to-modern-recommendation
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Update ERC-1363: Update text to modern recommendations #403
vittominacori
wants to merge
8
commits into
ethereum:master
from
vittominacori:feat/update-texts-to-modern-recommendation
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vittominacori
changed the title
Update text to modern recommendation
Update text to modern recommendations
Apr 29, 2024
eip-review-bot
changed the title
Update text to modern recommendations
Update ERC-1363: Update text to modern recommendations
Apr 29, 2024
vittominacori
force-pushed
the
feat/update-texts-to-modern-recommendation
branch
from
May 7, 2024 07:59
80c2a7a
to
3c1ba1c
Compare
…github.com/vittominacori/ERCs into feat/update-texts-to-modern-recommendation
…pdate-texts-to-modern-recommendation
The commit 2832025 (as a parent of c8fe90c) contains errors. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to be more clear and understandable I've updated some text and sections in order to be compliant with the new recommendations.
The content of the ERC was not edited but only rewritten and reorganized in a more clear way (also because of the first version was of 2018).
I've requested these changes in a moment when the EIP repo was migrating and these were rejected. I hope they can be reviewed now that the process is almost completed.