Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ERC-7399: Don't revert on view functions. #401

Merged
merged 4 commits into from
Jun 7, 2024

Conversation

alcueca
Copy link
Contributor

@alcueca alcueca commented Apr 29, 2024

  • Minor edit on EIP title
  • Added Sam Bacha as author
  • Removed the concept of "unsupported asset", which was not explained. flashFee now doesn't ever revert to facilitate sorting of lenders by cost without having to work around uncomfortable reverts.

@eip-review-bot
Copy link
Collaborator

eip-review-bot commented Apr 29, 2024

✅ All reviewers have approved.

@eip-review-bot eip-review-bot changed the title EIP-3799: Don't revert on view functions. Update ERC-7399: Don't revert on view functions. Apr 29, 2024
@eip-review-bot eip-review-bot enabled auto-merge (squash) April 29, 2024 10:12
eip-review-bot
eip-review-bot previously approved these changes Apr 29, 2024
Copy link
Collaborator

@eip-review-bot eip-review-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

Copy link

The commit 541b8cf (as a parent of 8b185ea) contains errors.
Please inspect the Run Summary for details.

@github-actions github-actions bot added the w-ci label Apr 29, 2024
Copy link
Collaborator

@eip-review-bot eip-review-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

@eip-review-bot eip-review-bot merged commit c0448e9 into ethereum:master Jun 7, 2024
9 of 10 checks passed
@github-actions github-actions bot removed the w-ci label Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants