Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ERC: Ownership Delegation and Context for ERC-721 #391

Open
wants to merge 16 commits into
base: master
Choose a base branch
from

Conversation

ducthotran2010
Copy link

This proposal introduces an extension for ERC721 Non-Fungible Tokens (NFTs): specifying users for several contexts and differentiating owner and ownership rights for a token to use in several financial use cases for NFT.

@eip-review-bot
Copy link
Collaborator

eip-review-bot commented Apr 19, 2024

File ERCS/erc-7695.md

Requires 1 more reviewers from @axic, @g11tech, @SamWilsn, @xinbenlv

ERCS/erc-draft.md Outdated Show resolved Hide resolved
ERCS/erc-draft.md Outdated Show resolved Hide resolved
ducthotran2010 and others added 2 commits April 19, 2024 22:52
Co-authored-by: Andrew B Coathup <28278242+abcoathup@users.noreply.github.com>
Co-authored-by: Andrew B Coathup <28278242+abcoathup@users.noreply.github.com>
@github-actions github-actions bot removed the w-ci label Apr 19, 2024
@github-actions github-actions bot added the w-ci label Apr 19, 2024
@ducthotran2010 ducthotran2010 changed the title Add ERC: Ownership Delegation and Context for Non-Fungible Token Add ERC: Delegation, Context for Non-Fungible Token Apr 20, 2024
@github-actions github-actions bot added w-ci and removed w-ci labels Apr 20, 2024
Copy link

The commit e2e7f73 (as a parent of b8bfeca) contains errors.
Please inspect the Run Summary for details.

@github-actions github-actions bot removed the w-ci label Apr 20, 2024
@eip-review-bot eip-review-bot changed the title Add ERC: Delegation, Context for Non-Fungible Token Add ERC: Ownership Delegation and Context for ERC-721 Apr 25, 2024
@ducthotran2010 ducthotran2010 marked this pull request as ready for review April 29, 2024 10:19
@ducthotran2010
Copy link
Author

Hi reviewers, all the commented issues are resolved. This proposal is refined to be a draft and ready for review. Please take a look @axic, @g11tech, @SamWilsn, @xinbenlv

---
eip: 7695
title: Ownership Delegation and Context for ERC-721
description: Extends ERC-721 for financial use cases without changing owner
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your description is a bit vague. Think you could expand it a bit?

Maybe something about creating different contexts, and delegating permissions within those contexts, without changing the ultimate owner of the token?

requires: 165, 721
---

## **Abstract**
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## **Abstract**
## Abstract


## **Abstract**

This proposal introduces an extension for [ERC-721](./eip-721.md) Non-Fungible Tokens (NFTs): specifying users for several contexts and differentiating owner and ownership rights for a token to use in several financial use cases for NFT without changing owner.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your abstract is pretty good, except maybe a tad too short. What differentiates your proposal from other similar ones? How does it work on a technical level?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have a slight preference for SVG images, but if you cannot provide one, this PNG is fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants