Update ERC-2333: Move to Last Call #386
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eip-review-bot
changed the title
eip-review-bot
changed the title
|
Taking this straight to |
joshim2021
approved these changes
May 6, 2024
19 tasks
eip-review-bot
changed the title
SamWilsn
reviewed
May 28, 2024
| @@ -1,32 +1,25 @@ | |||
| --- | |||
| eip: 2334 | |||
| title: BLS12-381 Deterministic Account Hierarchy | |||
| description: BLS12-381 Deterministic account hierarchy structure | |||
There was a problem hiding this comment.
Your description doesn't really add a lot of information that isn't already in the title. Maybe:
Suggested change
| description: BLS12-381 Deterministic account hierarchy structure | |
| description: Define the purpose of a key (or family of keys) within a tree of keys. |
| discussions-to: https://github.com/ethereum/EIPs/issues/2338 | ||
| status: Stagnant | ||
| discussions-to: https://ethereum-magicians.org/t/bls-keys-related-erc-discussion-erc-2333-2334-2335/19774 | ||
| status: Final |
There was a problem hiding this comment.
Suggested change
| status: Final | |
| status: Last Call | |
| last-call-deadline: 2024-06-11 |
You'll need to go through a last call period.
| discussions-to: https://github.com/ethereum/EIPs/issues/2339 | ||
| status: Stagnant | ||
| discussions-to: https://ethereum-magicians.org/t/bls-keys-related-erc-discussion-erc-2333-2334-2335/19774 | ||
| status: Final |
There was a problem hiding this comment.
Suggested change
| status: Final | |
| status: Last Call | |
| last-call-deadline: 2024-06-11 |
| @@ -1,36 +1,29 @@ | |||
| --- | |||
| eip: 2335 | |||
| title: BLS12-381 Keystore | |||
| description: Keystore for storing BLS12-381 keys | |||
There was a problem hiding this comment.
Suggested change
| description: Keystore for storing BLS12-381 keys | |
| description: JSON format for the storage and interchange of BLS12-381 private keys. |
Your simple summary was great. Might as well re-use it!
|
The commit 31e6d29 (as a parent of dc6a671) contains errors. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bring ERC 2333, 2334, 2335 up to date.
These ERCs are already the standard for BLS keys as used within the Beacon chain. This PR brings the ERCs up to date and sets them to
Last Callso they can becomeFinalASAP to line up with their actual status.