-
Notifications
You must be signed in to change notification settings - Fork 341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ERC: Smart Blobs #380
base: master
Are you sure you want to change the base?
Add ERC: Smart Blobs #380
Conversation
Co-authored-by: Andrew B Coathup <28278242+abcoathup@users.noreply.github.com>
Co-authored-by: Andrew B Coathup <28278242+abcoathup@users.noreply.github.com>
The commit 107a1bc (as a parent of 1ff114a) contains errors. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This proposal reads more like documentation for a specific project than a specification for a protocol. For example, curl
commands aren't exactly common in EIPs.
You need to rewrite this as a document describing the expected behaviour of the system and the integration points with other systems/users.
|
||
|
||
## Abstract | ||
This EIP introduces "smart blobs" and standardizes an implementation of the SmartWeave protocol on top of [EIP-4844](./eip-4844.md) blobs, ensuring a certain degree of compatibility with the EVM. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your abstract is a bit too light on technical details. It should give enough information that the reader has a high level overview of how the proposal works, in addition to what problems it solves.
- `type 1` : contract deployments | ||
- `type 2` : contract calls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- `type 1` : contract deployments | |
- `type 2` : contract calls | |
- *type 1* : contract deployments | |
- *type 2* : contract calls |
Only use backticks (`) for inline code.
This proposal hopes to accomplish the following: | ||
* Standardizing the usage of EIP-4844 blobs within the scope of creating execution machines on top of the blobspace | ||
* Utilize SmartWeave's lazy evaluation paradigm within the EVM space. | ||
* Extend the capabilities of lazy evaluation by using window-timegated DA | ||
* Utilize blobspace instead of calldata to leverage off-chain execution more cheaply | ||
* Write Smart Blobs in any interpreted language, or in a compiled language provided it uses WASM (JavaScript, Python, Rust, Lua, etc.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Rationale section is used to explain choices made in the proposal, while this content seems to be justifying the EIP as a whole (and so belongs in the Motivation section.) My favourite analogy is:
Motivation: We need to build a shed because...
Rationale: We painted the shed red because...
|
||
## Reference Implementation | ||
|
||
A reference implementation of this proposal is currently being developed by the weaveVM organization. The ongoing development can be accessed on GitHub at the following URL: `https://github.com/weavevm/blobvm-core`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove the external link.
|
||
|
||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://ethereum-magicians.org/t/erc-7689-smart-blobs/19672