Add ERC: Auxiliary Funds Capability #372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ All reviewers have approved. |
SamWilsn
reviewed
Apr 10, 2024
|
The commit 644d832 (as a parent of f9adc05) contains errors. |
abcoathup
reviewed
Apr 15, 2024
Co-authored-by: Andrew B Coathup <28278242+abcoathup@users.noreply.github.com>
SamWilsn
reviewed
Jun 7, 2024
| --- | ||
| eip: 7682 | ||
| title: Auxiliary Funds Capability | ||
| description: A way for wallets to indicate to apps that they have access to additional funds |
There was a problem hiding this comment.
Suggested change
| description: A way for wallets to indicate to apps that they have access to additional funds | |
| description: An ERC-5792 capability allowing wallets to indicate that they have access to additional funds. |
Your description was fine before, but I feel like explicitly mentioning 5792 in the description might be useful.
|
|
||
| ## Abstract | ||
|
|
||
| An [EIP-5792](./eip-5792.md) compliant capability that allows wallets to indicate to apps that they have access to funds beyond those that can be accounted for by looking up balances onchain given the wallet's address. |
There was a problem hiding this comment.
It'd be nice to have a bit more technical detail in the abstract. How do wallets indicate this? Where could these funds come from?
SamWilsn
approved these changes
Jun 7, 2024
eip-review-bot
approved these changes
Jun 7, 2024
eip-review-bot
approved these changes
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Defines an EIP-5792 compliant capability that allows wallets to indicate to apps that they have access to funds beyond those that can be accounted for by looking up balances onchain given the wallet's address.
https://ethereum-magicians.org/t/add-erc-auxiliary-funds-capability/19599