-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add EIP: ETH transfers emit a log #8575
base: master
Are you sure you want to change the base?
Conversation
All ETH-transferring calls emit a log.
File
|
The commit 136f035 (as a parent of 3668b6f) contains errors. |
EIPS/eip-9999.md
Outdated
title: ETH transfers emit a log | ||
description: All ETH transfers emit a log | ||
author: Vitalik Buterin (@vbuterin), Peter Davies (@petertdavies) | ||
discussions-to: https://ethereum-magicians.org/t/eip-all-value-transferring-calls-create-a-log/20034 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
discussions-to: https://ethereum-magicians.org/t/eip-all-value-transferring-calls-create-a-log/20034 | |
discussions-to: https://ethereum-magicians.org/t/eip-7708-eth-transfers-emit-a-log/20034 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tests
I want to make a transfer with my tokens. To borrow usd. I'm not sure what to do or how to go by doing it??? |
import azure.functions as func Client initializationclient = Elasticsearch( def main(request: func.HttpRequest) -> func.HttpResponse: from elasticsearch import Elasticsearch Client initializationclient = Elasticsearch( def main(request): C:\Projects\Code\WanPathFileShareSystem-v2-QA\MyWorkDrive.Solutions.Client\WanPath.WopiAuth.Account.LoginWopi.btnStep2_Click(Object sender, EventArgs e) in C:\Projects\Code\WanPathFileShareSystem-v2-QA\MyWorkDrive.Solutions.Client\WanPath.WopiAuth\Account\LoginWopi.aline 1:4
|
Co-authored-by: Andrew B Coathup <28278242+abcoathup@users.noreply.github.com>
my kingdom for a log on CREATE as well |
There's nothing I desire more than this. |
Would emitting these new logs be free or incur the default log emit costs? Asking because if it costs something, then gas accounting can get a bit funky in certain places (e.g. if I want to emit a log with the total fees paid, which depend on emitting the log itself, before emitting the log itself :P) |
Would emphasize non-traditional transfers need (possibly duplicative) logs as well to ensure the UX assumptions of transfers holds. Adding ETH transfer logs without these special cases handled will result in ethereum data providers to be inundated with faulty assumptions from their users (most specifically, net transfers != ETH balance at a block height) ETH Gas payments should also emit event that corresponds with a transfer to 0x0000...0000 ETH beacon chain rewards should emit contract self destructs should emit 2 transfers Data providers currently use traces to identify ETH transfers, so logs would be a small quality of life improvement if done well, but could actually cause more headaches if special cases (like self destruct bypassing contract @karalabe |
agree with @charlieflipside . it should include fees payments and block rewards. My only concern here is that this change is going to almost duplicate the amount of logs per day: Dune Dashboard - EIP-7708 |
All ETH-transferring calls emit a log.