Merge/foundation release/1.13.14 #623

meowsbits · 2024-03-04T23:25:46Z

Supersedes #621

What's Changed

bump min Go version to 1.21

Fixed

Comparison with last release: v1.13.1..v1.12.19
Docker images published under etclabscore/core-geth.

Co-authored-by: Felix Lange <fjl@twurst.com>

Co-authored-by: Martin HS <martin@swende.se> Co-authored-by: Felix Lange <fjl@twurst.com>

This PR schedules the cancun fork for the goerli testnet as discussed on ACD. Spec: ethereum/execution-specs#860 We schedule: goerli at 1705473120

When managing geth, it is sometimes desirable to do a partial wipe; deleting state but retaining freezer data. A partial wipe can be somewhat tricky to accomplish. This change implements the ability to perform partial wipe by making it possible to run geth removedb non-interactive, using command line options instead.

update logger test data

This is a rewrite of the 'simulated backend', an implementation of the ethclient interfaces which is backed by a simulated blockchain. It was getting annoying to maintain the old version of the simulated backend feature because there was a lot of code duplication with the main client. The new version is built using parts that we already have: an in-memory geth node instance running in developer mode provides the chain, while the Go API is provided by ethclient. A backwards-compatibility wrapper is provided, but the simulated backend has also moved to a more sensible import path: github.com/ethereum/go-ethereum/ethclient/simulated --------- Co-authored-by: Felix Lange <fjl@twurst.com> Co-authored-by: Gary Rong <garyrong0905@gmail.com>

* Fix broken badge in README.md Replaced broken Github link with IPFS link for long-term storage. * update go badge Co-authored-by: lightclient <14004106+lightclient@users.noreply.github.com> --------- Co-authored-by: lightclient <14004106+lightclient@users.noreply.github.com>

eth: refactor `GetVM`

* accounts, ethclient: minor tweaks on the new simulated backend * ethclient/simulated: add an initial batch of gas options * accounts, ethclient: remove mandatory gasLimit constructor param * accounts, ethclient: minor option naming tweaks

This test was failling consistently on the github 32-bit build probably due to slow IO. Skipping it for that green check.

Given the discussions around deprecating pending (see #28623 or ethereum/execution-apis#495), we can move away from using the pending block internally, and use latest instead

Updates the reference tests to the latest version

Co-authored-by: Felix Lange <fjl@twurst.com>

…tPos only if config configs it Date: 2024-02-29 09:07:15-07:00 Signed-off-by: meows <b5c6@protonmail.com>

…rge config Date: 2024-02-29 09:07:41-07:00 Signed-off-by: meows <b5c6@protonmail.com>

…hash ModeFake, fixes tests The testdata use ethash as their consensus engine, but define 0-values for all mixhashes. So we need to not validate the PoW seals for the test. See the comment about how we might create a second testdata suite that would actually define mixhashes which could be validated by a real ethash engine. Date: 2024-02-29 09:40:40-07:00 Signed-off-by: meows <b5c6@protonmail.com>

…nt 1

--- FAIL: TestDifficulty (0.01s) --- FAIL: TestDifficulty/blockgenesistest.json (0.00s) panic: json: cannot unmarshal array into Go value of type map[string]map[string]json.RawMessage in file testdata/BasicTests/blockgenesistest.json

Date: 2024-03-01 14:21:37-07:00 Signed-off-by: meows <b5c6@protonmail.com>

Conflicts: core/txpool/blobpool/blobpool.go eth/catalyst/api.go eth/catalyst/api_test.go params/version.go

Date: 2024-03-04 09:46:29-07:00 Signed-off-by: meows <b5c6@protonmail.com>

Date: 2024-03-04 09:48:08-07:00 Signed-off-by: meows <b5c6@protonmail.com>

…kipped Date: 2024-03-06 11:57:50-07:00 Signed-off-by: meows <b5c6@protonmail.com>

diega · 2024-03-18T19:37:38Z

.github/workflows/go.yml

+
+jobs:
+  build:
+    runs-on: self-hosted


we would probably need to configure this runner on our side

diega · 2024-03-18T19:39:33Z

.travis.yml

@@ -0,0 +1,168 @@
+language: go
+go_import_path: github.com/ethereum/go-ethereum


besides changing this, we could try to configure TravisCI to see if we can match some of this builds

Dockerfile.alltools

diega · 2024-03-25T17:49:49Z

cmd/devp2p/README.md

+        --verbosity 5                  \
+        --authrpc.jwtsecret 0x7365637265747365637265747365637265747365637265747365637265747365
+
+Note that the tests also require access to the engine API.


Based on this note I'm not sure if we should integrate devp2p changes without checking if it still works for our diagnosing usage

cmd/devp2p/rlpxcmd.go

cmd/evm/runner.go

cmd/geth/main.go

ziogaschr · 2024-04-16T09:11:42Z

cmd/utils/flags.go

 	if ctx.IsSet(MaxPeersFlag.Name) {
 		cfg.MaxPeers = ctx.Int(MaxPeersFlag.Name)
-		if lightServer && !ctx.IsSet(LightMaxPeersFlag.Name) {


Once we release this version, we have to update our nodes to stop serving light clients.

cmd/utils/flags.go

consensus/ethash/ethash_test.go

core/genesis.go

params/types/ctypes/configurator_iface.go

cmd/faucet/faucet.go

ziogaschr · 2024-04-17T09:18:33Z

eth/downloader/downloader_test.go

@@ -752,9 +723,6 @@ func testMultiSynchronisation(t *testing.T, protocol uint, mode SyncMode) {
 func TestMultiProtoSynchronisation68Full(t *testing.T)  { testMultiProtoSync(t, eth.ETH68, FullSync) }
 func TestMultiProtoSynchronisation68Snap(t *testing.T)  { testMultiProtoSync(t, eth.ETH68, SnapSync) }
 func TestMultiProtoSynchronisation68Light(t *testing.T) { testMultiProtoSync(t, eth.ETH68, LightSync) }
-func TestMultiProtoSynchronisation67Full(t *testing.T)  { testMultiProtoSync(t, eth.ETH67, FullSync) }


Do we want to keep ETH67 and its tests?

What is the latest version implemented by besu and Erigon?

This is the PR removing it ethereum/go-ethereum#28956

PR that reverts the ETH67 removal #629

Ohh, @meowsbits @diega we have to merge this one I think. If yes, then we have to rerun our sync test.

ziogaschr · 2024-04-17T11:07:39Z

I have finished with the review and made some comments. After we check/work on all the comments here, we can run a sync test and merge it I think.

ziogaschr · 2024-04-25T13:55:30Z

eth/protocols/eth/handler.go

We can probably remove this comment https://github.com/etclabscore/core-geth/pull/623/files#diff-5beb4052baf94e3025566d929c63974350e4b1eae18cce8eb21b4579d6788ffeR98.
@meowsbits is there anything else to do about it?

My browser is struggling to load the linked comment. Please clarify which comment you're pointing to.

My browser can't load it either. It was probably a comment in code with a TODO on your name.

sandakersmann and others added 30 commits January 4, 2024 15:03

internal/flags: update copyright year to 2024 (#28760)

99eb49e

Co-authored-by: Felix Lange <fjl@twurst.com>

ethclient: simplify error handling in TransactionReceipt (#28748)

e3eeb64

Co-authored-by: Martin HS <martin@swende.se> Co-authored-by: Felix Lange <fjl@twurst.com>

eth/downloader, eth/filters: use defer to call Unsubscribe (#28762)

877d094

log: emit error level string as "error", not "eror" (#28774)

07b17f9

eth/filters: fix early Unsubscribe of log events (#28769)

e7fa158

cmd/devp2p/internal/ethtest: fix typos in comments (#28772)

f29520f

params, core/forkid: schedule cancun fork on goerli (#28719)

cfff3cb

This PR schedules the cancun fork for the goerli testnet as discussed on ACD. Spec: ethereum/execution-specs#860 We schedule: goerli at 1705473120

accounts/abi: fix bigInt topic encoding (#28764)

d0edc5a

cmd/geth: update log test data (#28780)

9e018ce

update logger test data

params: go-ethereum v1.13.9 stable

4f82531

Merge branch 'master' into release/1.13

dd938d1

params: begin v1.13.10 release cycle

daa2e5d

version: release v1.13.10 to fix bad tag

a162091

Merge branch 'master' into release/1.13

bc0be1b

params: begin v1.13.11 release cycle

2e8b118

eth: minor change of config-accessor (#28782)

6e235c0

eth: refactor `GetVM`

cmd: fix typos (#28798)

ae4ea04

build: fix typo in comment (#28800)

7280a5b

cmd/geth, internal/debug: get rid of by-default log config (#28801)

43ba7d6

cmd/devp2p/internal/ethtest: skip large tx test on github build (#28794)

a608c0a

This test was failling consistently on the github 32-bit build probably due to slow IO. Skipping it for that green check.

p2p/dnsdisc: use strings.Cut over strings.IndexByte (#28787)

1335ba5

internal/ethapi: avoid using pending for defaults (#28784)

407f779

Given the discussions around deprecating pending (see #28623 or ethereum/execution-apis#495), we can move away from using the pending block internally, and use latest instead

core/state: unexport GetOrNewStateObject (#28804)

29b7355

cmd/rlpdump: add -pos flag, displaying byte positions (#28785)

1485814

tests: update reference tests (#28778)

89ccc68

Updates the reference tests to the latest version

ethclient: add tests for TransactionInBlock (#28283)

7596db5

Co-authored-by: Felix Lange <fjl@twurst.com>

meowsbits and others added 10 commits February 29, 2024 09:07

internal/ethapi: TestCall: use MergedTestChainConfig (==upstream), Se…

1d04adf

…tPos only if config configs it Date: 2024-02-29 09:07:15-07:00 Signed-off-by: meows <b5c6@protonmail.com>

core/vm,internal/ethapi: install new cg-specific TestCall with pre-me…

1b324ca

…rge config Date: 2024-02-29 09:07:41-07:00 Signed-off-by: meows <b5c6@protonmail.com>

miner: miner: worker_test.go:300: receipt number mismatch: have 0, wa…

2fe7ea7

…nt 1

tests: tests: fix TestDifficulty

836e215

--- FAIL: TestDifficulty (0.01s) --- FAIL: TestDifficulty/blockgenesistest.json (0.00s) panic: json: cannot unmarshal array into Go value of type map[string]map[string]json.RawMessage in file testdata/BasicTests/blockgenesistest.json

accounts: fix HdPath tests to use SetCoinTypeConfiguration

9c1164c

tests: update submodule tests/testdata to ::release/1.13 version

a835d41

Date: 2024-03-01 14:21:37-07:00 Signed-off-by: meows <b5c6@protonmail.com>

Merge branch 'release/1.13' into merge/foundation-release/1.13.14

8efa594

Conflicts: core/txpool/blobpool/blobpool.go eth/catalyst/api.go eth/catalyst/api_test.go params/version.go

core/txpool: s/params/vars/ BlobTxMinBlobGasprice

255f6d1

Date: 2024-03-04 09:46:29-07:00 Signed-off-by: meows <b5c6@protonmail.com>

core/txpool/blobpool: undefined: params.BlobTxMinBlobGasprice

3d43b20

Date: 2024-03-04 09:48:08-07:00 Signed-off-by: meows <b5c6@protonmail.com>

meowsbits requested a review from ziogaschr March 4, 2024 23:25

meowsbits mentioned this pull request Mar 4, 2024

Merge/foundation release/1.13.13 #621

Closed

meowsbits changed the base branch from master to merge/foundation-release/1.13.5 March 4, 2024 23:31

tests: execStateTest: actually skip forks that are registered to be s…

cbb7f77

…kipped Date: 2024-03-06 11:57:50-07:00 Signed-off-by: meows <b5c6@protonmail.com>

Base automatically changed from merge/foundation-release/1.13.5 to master March 11, 2024 13:10

diega reviewed Mar 28, 2024

View reviewed changes

ziogaschr reviewed Apr 16, 2024

View reviewed changes

cmd/utils/flags.go Show resolved Hide resolved

ziogaschr reviewed Apr 16, 2024

View reviewed changes

consensus/ethash/ethash_test.go Show resolved Hide resolved

ziogaschr reviewed Apr 16, 2024

View reviewed changes

core/genesis.go Outdated Show resolved Hide resolved

ziogaschr reviewed Apr 17, 2024

View reviewed changes

params/types/ctypes/configurator_iface.go Show resolved Hide resolved

ziogaschr reviewed Apr 17, 2024

View reviewed changes

cmd/faucet/faucet.go Show resolved Hide resolved

ziogaschr reviewed Apr 17, 2024

View reviewed changes

ziogaschr added 4 commits April 17, 2024 15:05

go.mod: set go.mod version to 1.21

b9eb08a

go.mod,go.sum: go mod tidy

8691c58

.github/workflows: update GitHub workflows to use go version 1.21

86f3184

core: install the remaining Cancun EIP overrides

9290ad9

ziogaschr reviewed Apr 25, 2024

View reviewed changes

ziogaschr mentioned this pull request Apr 25, 2024

Revert ETH67 removal #629

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Merge/foundation release/1.13.14 #623

Merge/foundation release/1.13.14 #623

meowsbits commented Mar 4, 2024 •

edited by ziogaschr

diega Mar 18, 2024

diega Mar 18, 2024

diega Mar 25, 2024

ziogaschr Apr 16, 2024

ziogaschr Apr 17, 2024

ziogaschr Apr 17, 2024

ziogaschr Apr 17, 2024

ziogaschr Apr 25, 2024

ziogaschr May 21, 2024

ziogaschr commented Apr 17, 2024

ziogaschr Apr 25, 2024

meowsbits May 20, 2024

ziogaschr May 21, 2024

		@@ -0,0 +1,168 @@
		language: go
		go_import_path: github.com/ethereum/go-ethereum

Merge/foundation release/1.13.14 #623

Are you sure you want to change the base?

Merge/foundation release/1.13.14 #623

Conversation

meowsbits commented Mar 4, 2024 • edited by ziogaschr

What's Changed

Fixed

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ziogaschr commented Apr 17, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

meowsbits commented Mar 4, 2024 •

edited by ziogaschr