Add Mordor Mining Guide #588
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris-mercer
commented
Nov 21, 2023
chris-mercer
commented
- Update Build from Source: Go version and Installation instructions
- Update Installation: Fix broken link, Add --classic flags and Installation instructions
- Add Mordor Mining Guide
- Spiral upgrade release
- Spiral Upgrade release
meowsbits
reviewed
Jan 8, 2024
|
|
||
| ```shell | ||
| $ wget https://github.com/etclabscore/core-geth/releases/download/v1.12.17/core-geth-linux-v1.12.17.zip # Update to the most current release version | ||
| $ sudo unzip core-geth-linux-v1.12.17.zip -d /bin/ # Update to the most current release version |
There was a problem hiding this comment.
Normally the best place for user-installed programs is in /usr/local/bin.
https://unix.stackexchange.com/questions/8656/usr-bin-vs-usr-local-bin-on-linux
Suggested change
| $ sudo unzip core-geth-linux-v1.12.17.zip -d /bin/ # Update to the most current release version | |
| $ sudo unzip core-geth-linux-v1.12.17.zip -d /usr/local/bin # Update to the most current release version |
Here and other places.
meowsbits
reviewed
Jan 8, 2024
|
|
||
| Binary archives are published at https://github.com/etclabscore/core-geth/releases. Find the latest one for your OS, download it, (check the SHA sum), unarchive it, and run! | ||
|
|
||
| Tip: When running Core-geth use `--classic` flag for Ethereum Classic mainnet. |
There was a problem hiding this comment.
How about we use the markdown !!! tips instead for these Tip:s?
Suggested change
| Tip: When running Core-geth use `--classic` flag for Ethereum Classic mainnet. | |
| !!! tip "Run Ethereum Classic" | |
| When running Core-geth use `--classic` flag for Ethereum Classic mainnet. |
meowsbits
reviewed
Jan 8, 2024
| @@ -3,14 +3,31 @@ title: Installation | |||
| --- | |||
|
|
|||
| !!! tip "Build from Source" | |||
| Instructions to build from source can be found [here](core-geth/developers/build-from-source/). | |||
| Instructions to build from source can be found [here](https://etclabscore.github.io/core-geth/developers/build-from-source/) | |||
There was a problem hiding this comment.
Will it work to use a relative path instead? That'd be a little less brittle.
Suggested change
| Instructions to build from source can be found [here](https://etclabscore.github.io/core-geth/developers/build-from-source/) | |
| Instructions to build from source can be found [here](./core-geth/developers/build-from-source/) |
meowsbits
reviewed
Jan 8, 2024
| --- | ||
|
|
||
| !!! tip "Mordor Testnet" | ||
| Mordor is a PoW Ethereum Classic testnet. A testnet allows developers to perform specific tests. Developers may want to test protocol changes, test a smart contract, or interact with the network in anyway that does not require real EthClassic (ETC)—just don’t test on mainnet, mainnet is for production. |
There was a problem hiding this comment.
Suggested change
| Mordor is a PoW Ethereum Classic testnet. A testnet allows developers to perform specific tests. Developers may want to test protocol changes, test a smart contract, or interact with the network in anyway that does not require real EthClassic (ETC)—just don’t test on mainnet, mainnet is for production. | |
| Mordor is a PoW Ethereum Classic testnet. A testnet allows developers to test transactions before deploying them with real value on the mainnet. Developers may want to test protocol changes, test a smart contract, or interact with the network in any way that does not require real EthClassic (ETC)—just don’t test on mainnet, mainnet is for production. |
meowsbits
reviewed
Jan 8, 2024
| $ source ~/.bash_profile | ||
| $ go version | ||
| ``` | ||
|
|
There was a problem hiding this comment.
All three of these paragraphs are Go installation instructions. I'd prefer to defer simply to one -- the official Go docs -- rather than provide 3 redundant options which will need updating. The important part here -- and thanks for updating it :) -- is the minimum Go version.
meowsbits
reviewed
Jan 8, 2024
|
|
||
| You’ll notice listing the account will print the keystore file location.For example:keystore:///home/USER/.ethereum/mordor/keystore/UTC... | ||
|
|
||
| ## Run Mordor with Mining Enable |
There was a problem hiding this comment.
Suggested change
| ## Run Mordor with Mining Enable | |
| ## Run Mordor with Mining Enabled |
meowsbits
reviewed
Jan 8, 2024
|
|
||
| So, you’re running a Mordor node and mining testnet mETC. Woohoo! An easy way to double check you’re actually growing a Mordor testnet balance is on [Blockscout](https://etc-mordor.blockscout.com). Just search the account address you created earlier. | ||
|
|
||
| ## Add your Mordor Account to a Wallet? |
There was a problem hiding this comment.
Suggested change
| ## Add your Mordor Account to a Wallet? | |
| ## Add your Mordor Account to a Wallet (Optional) |
meowsbits
reviewed
Jan 8, 2024
| Enter the following in a new terminal window (ctrl + alt + t): | ||
|
|
||
| ```shell | ||
| touch start-mordor.sh && echo "geth --mordor --mine --minerthreads 1 --miner.etherbase 0x_INSERT_YOUR_ADDRESS_HERE_3a087" >start-mordor.sh && chmod +x start-mordor.sh |
There was a problem hiding this comment.
> will create (and truncate) the file if it does not already exist.
Suggested change
| touch start-mordor.sh && echo "geth --mordor --mine --minerthreads 1 --miner.etherbase 0x_INSERT_YOUR_ADDRESS_HERE_3a087" >start-mordor.sh && chmod +x start-mordor.sh | |
| echo "geth --mordor --mine --minerthreads 1 --miner.etherbase 0x_INSERT_YOUR_ADDRESS_HERE_3a087" >start-mordor.sh && chmod +x start-mordor.sh |
meowsbits
reviewed
Jan 8, 2024
| touch start-mordor.sh && echo "geth --mordor --mine --minerthreads 1 --miner.etherbase 0x_INSERT_YOUR_ADDRESS_HERE_3a087" >start-mordor.sh && chmod +x start-mordor.sh | ||
| ``` | ||
|
|
||
| touch start-mordor.sh to create the file && echo “the contents” into the shell script file && add chmod executable+x permissions to the file. |
There was a problem hiding this comment.
Suggested change
| touch start-mordor.sh to create the file && echo “the contents” into the shell script file && add chmod executable+x permissions to the file. | |
| Create or truncate the script file and echo the command into it, then make it executable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.