build(deps): bump github.com/fatih/color from 1.15.0 to 1.17.0 #17998

dependabot · 2024-05-13T17:34:32Z

Bumps github.com/fatih/color from 1.15.0 to 1.17.0.

Release notes

Sourced from github.com/fatih/color's releases.

v1.17.0

What's Changed

Fix multi-parameter println spacing by @klauspost in fatih/color#228

ci: update Go and Staticcheck versions by @fatih in fatih/color#222

Bump golang.org/x/sys from 0.14.0 to 0.17.0 by @dependabot in fatih/color#221

Bump actions/setup-go from 4 to 5 by @dependabot in fatih/color#217

Bump golang.org/x/sys from 0.17.0 to 0.18.0 by @dependabot in fatih/color#224

New Contributors

@klauspost made their first contribution in fatih/color#228

Full Changelog: fatih/color@v1.16.0...v1.17.0

v1.16.0

What's Changed

Update dependabot.yml by @ilyabrin in fatih/color#200

color: add newline after wrapping text by @fatih in fatih/color#192

[Test] Nil check added by @hyunsooda in fatih/color#203

fixes #206 (using underline with a different fg color breaks) by @gregpoirson in fatih/color#210

Dependency updates

Bump dominikh/staticcheck-action from 1.2.0 to 1.3.0 by @dependabot in fatih/color#201

Bump github.com/mattn/go-isatty from 0.0.17 to 0.0.18 by @dependabot in fatih/color#193

Bump golang.org/x/sys from 0.6.0 to 0.8.0 by @dependabot in fatih/color#195

Bump github.com/mattn/go-isatty from 0.0.18 to 0.0.19 by @dependabot in fatih/color#196

Bump golang.org/x/sys from 0.8.0 to 0.10.0 by @dependabot in fatih/color#199

Bump github.com/mattn/go-isatty from 0.0.19 to 0.0.20 by @dependabot in fatih/color#212

Bump golang.org/x/sys from 0.10.0 to 0.13.0 by @dependabot in fatih/color#209

Bump actions/setup-go from 3 to 4 by @dependabot in fatih/color#202

Bump actions/checkout from 3 to 4 by @dependabot in fatih/color#208

Bump golang.org/x/sys from 0.13.0 to 0.14.0 by @dependabot in fatih/color#213

New Contributors

@ilyabrin made their first contribution in fatih/color#200

@hyunsooda made their first contribution in fatih/color#203

@gregpoirson made their first contribution in fatih/color#210

Full Changelog: fatih/color@v1.15.0...v1.16.0

Commits

b6598b1 Merge pull request #228 from klauspost/fix-println-issue-218
00b1811 Fix multi-parameter println spacing
04994a8 Merge pull request #224 from fatih/dependabot/go_modules/golang.org/x/sys-0.18.0
7526cad Merge branch 'main' into dependabot/go_modules/golang.org/x/sys-0.18.0
8d058ca Merge pull request #222 from fatih/ci-updates
2ac809f Bump golang.org/x/sys from 0.17.0 to 0.18.0
51a7bbf ci: update Go and Staticcheck versions
799c49c Merge pull request #217 from fatih/dependabot/github_actions/actions/setup-go-5
f8e0ec9 Merge branch 'main' into dependabot/github_actions/actions/setup-go-5
298abd8 Merge pull request #221 from fatih/dependabot/go_modules/golang.org/x/sys-0.17.0
Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

@dependabot rebase will rebase this PR
@dependabot recreate will recreate this PR, overwriting any edits that have been made to it
@dependabot merge will merge this PR after your CI passes on it
@dependabot squash and merge will squash and merge this PR after your CI passes on it
@dependabot cancel merge will cancel a previously requested merge and block automerging
@dependabot reopen will reopen this PR if it is closed
@dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
@dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
@dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [github.com/fatih/color](https://github.com/fatih/color) from 1.15.0 to 1.17.0. - [Release notes](https://github.com/fatih/color/releases) - [Commits](fatih/color@v1.15.0...v1.17.0) --- updated-dependencies: - dependency-name: github.com/fatih/color dependency-type: indirect update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>

k8s-ci-robot · 2024-05-13T17:34:43Z

Hi @dependabot[bot]. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

codecov-commenter · 2024-05-13T17:53:18Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.90%. Comparing base (d0ea231) to head (f229259).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #17998      +/-   ##
==========================================
- Coverage   69.01%   68.90%   -0.12%     
==========================================
  Files         415      415              
  Lines       34963    34963              
==========================================
- Hits        24131    24090      -41     
- Misses       9455     9483      +28     
- Partials     1377     1390      +13

Flag	Coverage Δ
all	`68.90% <ø> (-0.12%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Reference: - etcd-io#17998 Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>

henrybear327 · 2024-05-17T21:57:27Z

Fully indirect

➜  etcd git:(dependency_update/5_17_24) ✗ grep -Ri "github.com/fatih/color v" | grep -v sum      
./go.mod:       github.com/fatih/color v1.15.0 // indirect
./tools/mod/go.mod:     github.com/fatih/color v1.16.0 // indirect
./etcdctl/go.mod:       github.com/fatih/color v1.15.0 // indirect
./tests/go.mod: github.com/fatih/color v1.15.0 // indirect

henrybear327 · 2024-05-17T22:03:16Z

Fully indirect

➜  etcd git:(dependency_update/5_17_24) ✗ grep -Ri "github.com/fatih/color v" | grep -v sum      
./go.mod:       github.com/fatih/color v1.15.0 // indirect
./tools/mod/go.mod:     github.com/fatih/color v1.16.0 // indirect
./etcdctl/go.mod:       github.com/fatih/color v1.15.0 // indirect
./tests/go.mod: github.com/fatih/color v1.15.0 // indirect

@ivanvc ./tools/mod somehow has v1.16.0, others all have v1.15.0.

They are all indirect, so I am not updating any of them now. Just flagging this to you and see if you like to have the versions aligned.

ivanvc · 2024-05-17T22:24:36Z

@ivanvc ./tools/mod somehow has v1.16.0, others all have v1.15.0.

They are all indirect, so I am not updating any of them now. Just flagging this to you and see if you like to have the versions aligned.

I think it's because /tools/mod depends on it because of github.com/golangci/golangci-lint/pkg/commands, and the rest (etcdctl/, tests/ [and /]) because of github.com/cheggaaa/pb/v3.

henrybear327 · 2024-05-17T22:35:17Z

@ivanvc ./tools/mod somehow has v1.16.0, others all have v1.15.0.
They are all indirect, so I am not updating any of them now. Just flagging this to you and see if you like to have the versions aligned.

I think it's because /tools/mod depends on it because of github.com/golangci/golangci-lint/pkg/commands, and the rest (etcdctl/, tests/ [and /]) because of github.com/cheggaaa/pb/v3.

Do we want to align the version in this case? :)

ivanvc · 2024-05-17T23:07:46Z

I don't have an opinion on this. I think different direct dependencies may require different versions of indirect dependencies, which should be fine. @ahrtr, any advice? Should we update the indirect dependency to match the versions?

ahrtr · 2024-05-18T05:50:05Z

Overall not a big deal, but it would be better to make it consistent. Proposed actions,

bump the dependency to 1.17.0 for all modules;
I see etcdctl also depends on it, please check what's the impact on etcdctl.

Thanks.

henrybear327 · 2024-05-18T09:56:00Z

Overall not a big deal, but it would be better to make it consistent. Proposed actions,

bump the dependency to 1.17.0 for all modules;

I see etcdctl also depends on it, please check what's the impact on etcdctl.

Thanks.

Thanks @ivanvc and @ahrtr for the comments. I will apply the proposed actions accordingly now.

henrybear327 · 2024-05-18T10:03:25Z

Updated as requested.

➜  etcd git:(dependency_update/5_18_24) ✗ grep -Ri "github.com/fatih/color v" | grep -v sum
./go.mod:       github.com/fatih/color v1.17.0 // indirect
./tools/mod/go.mod:     github.com/fatih/color v1.17.0 // indirect
./etcdctl/go.mod:       github.com/fatih/color v1.17.0 // indirect
./tests/go.mod: github.com/fatih/color v1.17.0 // indirect

henrybear327 · 2024-05-18T10:07:14Z

@ahrtr may I ask what is there to check for the impact on etcdctl?

What I currently know is that this package is used to color the output for the console progress bar.

➜  etcdctl git:(dependency_update/5_18_24) ✗ go mod why github.com/fatih/color
# github.com/fatih/color
go.etcd.io/etcd/etcdctl/v3/ctlv3/command
github.com/cheggaaa/pb/v3
github.com/fatih/color

Acted according to etcd-io#17998 (comment) Reference: - etcd-io#17998 Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>

ahrtr · 2024-05-18T12:11:00Z

@ahrtr may I ask what is there to check for the impact on etcdctl?

What I currently know is that this package is used to color the output for the console progress bar.

Thanks for the confirmation. It's just indirectly used by etcdctl. It should be fine.

ahrtr · 2024-05-18T12:11:44Z

superseded by #18026

dependabot · 2024-05-18T12:11:46Z

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

dependabot bot added dependencies Pull requests that update a dependency file go Pull requests that update Go code labels May 13, 2024

k8s-ci-robot added the needs-ok-to-test label May 13, 2024

henrybear327 added a commit to henrybear327/etcd that referenced this pull request May 17, 2024

dependency: bump github.com/fatih/color from 1.15.0 to 1.17.0

89774d3

Reference: - etcd-io#17998 Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>

henrybear327 mentioned this pull request May 17, 2024

[2024-05-13] Bump dependency updates identified by dependabot #18024

Merged

henrybear327 added a commit to henrybear327/etcd that referenced this pull request May 18, 2024

dependency: bump github.com/fatih/color from 1.15.0 to 1.17.0

48f5117

Acted according to etcd-io#17998 (comment) Reference: - etcd-io#17998 Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>

henrybear327 mentioned this pull request May 18, 2024

[2024-05-13] Bump dependency updates identified by dependabot #18026

Merged

ahrtr closed this May 18, 2024

dependabot bot deleted the dependabot/go_modules/github.com/fatih/color-1.17.0 branch May 18, 2024 12:11

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

build(deps): bump github.com/fatih/color from 1.15.0 to 1.17.0 #17998

build(deps): bump github.com/fatih/color from 1.15.0 to 1.17.0 #17998

dependabot bot commented on behalf of github May 13, 2024

k8s-ci-robot commented May 13, 2024

codecov-commenter commented May 13, 2024

henrybear327 commented May 17, 2024

henrybear327 commented May 17, 2024

ivanvc commented May 17, 2024

henrybear327 commented May 17, 2024

ivanvc commented May 17, 2024

ahrtr commented May 18, 2024

henrybear327 commented May 18, 2024

henrybear327 commented May 18, 2024

henrybear327 commented May 18, 2024

ahrtr commented May 18, 2024

ahrtr commented May 18, 2024

dependabot bot commented on behalf of github May 18, 2024

build(deps): bump github.com/fatih/color from 1.15.0 to 1.17.0 #17998

build(deps): bump github.com/fatih/color from 1.15.0 to 1.17.0 #17998

Conversation

dependabot bot commented on behalf of github May 13, 2024

v1.17.0

What's Changed

New Contributors

v1.16.0

What's Changed

Dependency updates

New Contributors

k8s-ci-robot commented May 13, 2024

codecov-commenter commented May 13, 2024

Codecov Report

henrybear327 commented May 17, 2024

henrybear327 commented May 17, 2024

ivanvc commented May 17, 2024

henrybear327 commented May 17, 2024

ivanvc commented May 17, 2024

ahrtr commented May 18, 2024

henrybear327 commented May 18, 2024

henrybear327 commented May 18, 2024

henrybear327 commented May 18, 2024

ahrtr commented May 18, 2024

ahrtr commented May 18, 2024

dependabot bot commented on behalf of github May 18, 2024