Add shareable URLs #138
Open
Add shareable URLs #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cause the URL to change on input, and the input to change with the URL. Adds the following URL formats:
- /#!/{department code}
- /#!/{postal code}
- /#!/{postal code}/{section ID}
- /#!/{postal code}/{section ID}/{plot number}
- /#!/{plot code}
- /#!/{from date}-{until date}/{department code}
- /#!/{from date}-{until date}/{postal code}
- /#!/{from date}-{until date}/{postal code}/{section ID}
- /#!/{from date}-{until date}/{postal code}/{section ID}/{plot number}
- /#!/{from date}-{until date}/{plot code}
MetroConductor
force-pushed
the
hashbang-urls
branch
from
0a9e4f0
to
6fdc909
Compare
Change selection queue system to work correctly in all scenarios
MetroConductor
force-pushed
the
hashbang-urls
branch
from
6fdc909
to
e01d01b
Compare
The function resetParcelle() was called in changerSelection() while the map wasn't fully loaded, causing an error. This was fixed by checking the mapRendered boolean before said call, as it doesn't have any effect while the map is still loading any way.
MetroConductor
commented
Oct 19, 2023
Comment on lines
+827
to
+829
| }) | ||
| map.addLayer(departementsLayer) | ||
| map.addLayer(departementsContoursLayer) |
There was a problem hiding this comment.
Removed unnecessary indentation to improve readability
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed fix for #130. Cause the URL to change on input, and the input to change with the URL. Adds the following URL formats:
/#!/{department code}/#!/{postal code}/#!/{postal code}/{section ID}/#!/{postal code}/{section ID}/{plot number}/#!/{plot code}/#!/{from date}-{until date}/{department code}/#!/{from date}-{until date}/{postal code}/#!/{from date}-{until date}/{postal code}/{section ID}/#!/{from date}-{until date}/{postal code}/{section ID}/{plot number}/#!/{from date}-{until date}/{plot code}