[kernel][dist_util] Support 4-arity #hs_data.f_handshake_complete in dist_util.erl #8473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dist_util.erl Currently, `#hs_data.f_handshake_complete` supports a 3-arity function with the following function signature: ```erlang fun (DistCtrlr, Node, DHandle) -> void() ``` This PR extends the callback to also handle a 4-arity function: ```erlang fun (DistCtrlr, Node, DHandle) -> void() | fun (DistCtrlr, Node, DHandle, HsData) -> void() ``` Why? Once the handshake compeltes, there's currently no way to find out what the final `ChosenFlags` are between `this_node` and `other_node`; or what the value of `other_creation` was. The `HSData` variable is effectively discarded entirely when `con_loop` is called, so this information is lost for those wanting to implement an alternative dist protocol. See here for an example of how this information is used in [WhatsApp/erldist_filter](https://github.com/WhatsApp/erldist_filter): https://github.com/WhatsApp/erldist_filter/blob/main/apps/erldist_filter/src/erldist_filter_otp_26_0_2_inet_tcp_dist.erl#L931-L937
CT Test Results 4 files 199 suites 1h 47m 58s ⏱️ Results for commit ddd1c80. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
#hs_data.f_handshake_completesupports a 3-arity function with the following function signature:This PR extends the callback to also handle a 4-arity function:
Why? Once the handshake completes, there's currently no way to find out what the final
ChosenFlagsare betweenthis_nodeandother_node; or what the value ofother_creationwas.The
HSDatavariable is effectively discarded entirely whencon_loopis called, so this information is lost for those wanting to implement an alternative dist protocol.See here for an example of how this information is used in WhatsApp/erldist_filter: https://github.com/WhatsApp/erldist_filter/blob/main/apps/erldist_filter/src/erldist_filter_otp_26_0_2_inet_tcp_dist.erl#L931-L937