Make sets default to maps-based implementation #8429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CT Test Results 5 files 495 suites 1h 36m 14s ⏱️ Results for commit 7805c42. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
josevalim
force-pushed
the
jv-sets-v2-default
branch
from
f25b64a
to
01c95ad
Compare
bjorng
requested changes
Jun 3, 2024
Co-authored-by: Björn Gustavsson <bgustavsson@gmail.com>
|
Thanks! Added to our daily builds. |
bjorng
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have tagged it as a Erlang/OTP 28 change.
This should be safe to do as the new data type was introduced on Erlang/OTP 24. Feel free to close it if you believe it is too early.