Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Force Party instantiation to be made from Families #560

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Force Party instantiation to be made from Families #560

wants to merge 1 commit into from

Conversation

calum-chamberlain
Copy link
Member

What does this PR do?

Raises an assertion error if the wrong type is provided to Party on init

Why was it initiated? Any relevant Issues?

I frequently accidentally instantiate a party with a string. This should not be allowed.

PR Checklist

- [ ] develop base branch selected?

  • This PR is not directly related to an existing issue (which has no PR yet).
  • All tests still pass.
  • Any new features or fixed regressions are be covered via new tests.
  • Any new or changed features have are fully documented.
  • Significant changes have been added to CHANGES.md.
  • First time contributors have added your name to CONTRIBUTORS.md.

@calum-chamberlain
Force Party instantiation to be made from Families
0f1df04 
I frequently accidentally instantiate a party with a string. This should not be allowed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@calum-chamberlain