[Do not merge yet] Revert temporary workaround that allowed both old and new Path Resolver API #9966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… is smoother" This reverts commit d8460d0.
radeusgd
added
the
CI: No changelog needed
radeusgd
requested review from
jdunkerley,
GregoryTravis and
AdRiley
as code owners
radeusgd
changed the title
GregoryTravis
approved these changes
May 15, 2024
AdRiley
approved these changes
May 16, 2024
4 tasks
|
Superseded by #10050 |
mergify bot
pushed a commit
that referenced
this pull request
May 23, 2024
… path resolver workaround, partial fix for datalink resolver issue (#10050) - Supersedes #9966 as I wanted to test these changes in one go. - Fixes #10037 caused by lack of CI check and my oversight (forgot to run full tests after a minor change). - Fixes a regression after [file metadata fields were renamed](enso-org/cloud-v2@c09d856#diff-9f59b6a0ee3155efecdc70c1ea0c90ab5cde00b5623d84363118b1793f941c46R2037). - Fixes handling of creating new datalinks and using them after cache was cleared (e.g. workflow restart). - This was caused by troubles with path resolver. - The fix addresses the most common issue and adds a test for it (test flushes the caches to ensure path resolver is used instead of the cached value). - Some related issues were discovered on the cloud side, tracked by enso-org/cloud-v2#1252
MrFlashAccount
pushed a commit
that referenced
this pull request
May 25, 2024
… path resolver workaround, partial fix for datalink resolver issue (#10050) - Supersedes #9966 as I wanted to test these changes in one go. - Fixes #10037 caused by lack of CI check and my oversight (forgot to run full tests after a minor change). - Fixes a regression after [file metadata fields were renamed](enso-org/cloud-v2@c09d856#diff-9f59b6a0ee3155efecdc70c1ea0c90ab5cde00b5623d84363118b1793f941c46R2037). - Fixes handling of creating new datalinks and using them after cache was cleared (e.g. workflow restart). - This was caused by troubles with path resolver. - The fix addresses the most common issue and adds a test for it (test flushes the caches to ensure path resolver is used instead of the cached value). - Some related issues were discovered on the cloud side, tracked by enso-org/cloud-v2#1252
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Important Notes
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.