-
Notifications
You must be signed in to change notification settings - Fork 317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Search bar for settings #9887
base: develop
Are you sure you want to change the base?
Search bar for settings #9887
Conversation
yeah, there was an issue fixed on the weekend that breaks all currently open PRs |
@PabloBuchu merged with develop |
@PabloBuchu should be fixed now. one notable difference of the current impl is that the current page's content is still always filtered - so a lot of the time there may be a blank page if there are no matches on the current page. should be easy to change either way, so this is mostly just a heads up on how the current behavior works (as of latest commit) |
Pull Request Description
UX changes required for this PR:
MembersSettingsSection
to usereact-query
to avoid loading the members list every time a user types into the search barIncidental changes added to make this PR simpler:
Dashboard
and back down toTopBar
Important Notes
Screencast
Note: The end of this recording contains a bug where the "user account" section was not being matched. This bug has since been fixed.
settings-search-2.mp4
Code Review tips
settingsData.ts
contains the settings converted to JS objectsSettings.tsx
contains the new filtering logicSettings/Settings{Tab,Section,Entry,InputEntry,CustomEntry}
contains the components responsible for rendering the new JS objectsTesting instructions
SettingsEntryType.custom
insettingsData
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
The documentation has been updated, if necessary.Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
Unit tests have been written where possible.