Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Code Owners #10003

Merged
merged 2 commits into from
May 21, 2024
Merged

Update Code Owners #10003

merged 2 commits into from
May 21, 2024

Conversation

farmaazon
Copy link
Contributor

@farmaazon farmaazon commented May 20, 2024

Pull Request Description

  • Removed Michał from owners' list.
  • Removed old directories.
  • Added Ad as owner of GUI, so it will be easier to accept urgent quickfixes.

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    TypeScript,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • Unit tests have been written where possible.

@AdRiley
Copy link
Member

AdRiley commented May 20, 2024

Perhaps shouldn't have things with no code owner. Can you add me, James, Pavel and Hubert for those ones?

@farmaazon
Copy link
Contributor Author

Perhaps shouldn't have things with no code owner. Can you add me, James, Pavel and Hubert for those ones?

Even without owner, there is one accept needed. I just assumed it's ok to have no owner for shared files. But I can add them there, just I would add someone from GUI as well.

@farmaazon farmaazon added CI: Ready to merge This PR is eligible for automatic merge CI: No changelog needed Do not require a changelog entry for this PR. labels May 21, 2024
@jdunkerley
Copy link
Member

Just a CODEOWNERs change.

@jdunkerley jdunkerley closed this May 21, 2024
@jdunkerley jdunkerley deleted the wip/farmaazon/update-owners branch May 21, 2024 15:30
@jdunkerley jdunkerley restored the wip/farmaazon/update-owners branch May 21, 2024 15:30
@jdunkerley jdunkerley reopened this May 21, 2024
@jdunkerley jdunkerley merged commit 0596533 into develop May 21, 2024
58 of 63 checks passed
@jdunkerley jdunkerley deleted the wip/farmaazon/update-owners branch May 21, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants