Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #2365 about leaderboards functions #2386

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

YoungHypo
Copy link

A Solution for #2365 :

Description

Create std::list<LeaderboardRequest> LBRequestList for all download or upload leaderboards requests, and a LeaderboardRequest structure object to store the relevant parameters for the calls.

Example:

Take the steam_download_scores function leaderboards.cpp as an example, first add the leaderboard request of download_scores func to LBRequestList. When find_leaderboard func completes the find operation, the list will release the download request for execution. Therefore, the "download" of the leaderboard entry always follows the operation of finding the leaderboard, and the two remain synchronized.
@k0T0z

@YoungHypo YoungHypo changed the title fix #2365 about leaderboards func fix #2365 about leaderboards functions Mar 20, 2024
@k0T0z
Copy link
Contributor

k0T0z commented May 4, 2024

Is this PR ready for review?

@YoungHypo
Copy link
Author

YoungHypo commented May 4, 2024 via email

@k0T0z
Copy link
Contributor

k0T0z commented May 7, 2024

Interesting! I didn't know we could access GMS Steamworks' implementation, where did you get that?

@YoungHypo
Copy link
Author

YoungHypo commented May 8, 2024

Sorry, please forgive my inaccurate expression. It's not about accessing GMS, but learning the code of GMS's steamwork extension. I mean the GMEXT-Steamworks. It was your words in the discord group that inspired me.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants