-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#2371 fix:Steamworks logo is now showing #2372
base: master
Are you sure you want to change the base?
Conversation
@Daksh-10 Okay I will test your changes asap. I don't think we will need that |
@Daksh-10 Thank you for your contribution. I tested your PR and it's working but it needs some modifications before merging. |
start.sh
Outdated
@@ -0,0 +1,4 @@ | |||
#!/bin/bash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's remove this file as it's not related.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's also roll back this change as it affects nothing.
Ok I will change it, tq for reviewing it |
@k0T0z I reverted back the changes |
@Daksh-10 That's great, I think it's now ready for merging but let me check if it needs something else and then approve it. Great work 👌. |
In reference to #2371
On going through the code, I found out in the yaml file of steamworks, the icon tag didn't had the correct file name, I changed it, also the svg wasnot working, I clearly didn't know why so I rather did put a steamwork.png image, also I added a start.sh file, so ubuntu and debian users don't need to install it separately.