Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make setup.sh file for ubuntu users #2311

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

A-childs-encyclopedia
Copy link

No description provided.

@A-childs-encyclopedia
Copy link
Author

cc @JoshDreamland @RobertBColton

Copy link
Member

@JoshDreamland JoshDreamland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thanks for the patch! What makes this script so different from install.sh?

./install.sh
echo "Rebuilding compiler..."
make clean
make
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line could probably use a -j 4 or something to make life easier on most users.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's also possible to accept -jN as a parameter to the script and pass it to make using $1 or something

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Users could just invoke the script with MAKEFLAGS=-j32 in their environment of course.

git clone git https://github.com/enigma-dev/enigma-dev.git
cd enigma-dev
echo "Downloading easy startup script..."
wget https://pastebin.com/raw/aBAU4j3C -O start.sh
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a weird dep and a bit of a security hole; it probably makes more sense to either check this in or write it out as a string literal.

@A-childs-encyclopedia
Copy link
Author

Hi, this script is copied from the Linux installation page where it shows this script for Ubuntu users. I thought I'd add it here as making a file and pasting the stuff from the website is a bit of a hassle

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants